RCS1242: Do not pass non-read-only struct by read-only reference

[elachlan]

Description

I installed Roslynator and it found many references of RCS1242: Do not pass non-read-only struct by read-only reference
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1242.md

I was wondering if this is a legitimate issue:

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventProvider.cs

Lines 230 to 243 in a2df156

	// <SecurityKernel Critical="True" Ring="0">
	// <UsesUnsafeCode Name="Parameter filterData of type: Void*" />
	// <UsesUnsafeCode Name="Parameter callbackContext of type: Void*" />
	// </SecurityKernel>
	private unsafe void EtwEnableCallBack(
	in System.Guid sourceId,
	int controlCode,
	byte setLevel,
	long anyKeyword,
	long allKeyword,
	Interop.Advapi32.EVENT_FILTER_DESCRIPTOR* filterData,
	void* callbackContext
	)
	{

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventProvider.cs

Lines 1287 to 1294 in a2df156

	unsafe EventProvider.WriteEventErrorCode IEventProvider.EventWriteTransfer(
	long registrationHandle,
	in EventDescriptor eventDescriptor,
	IntPtr eventHandle,
	Guid* activityId,
	Guid* relatedActivityId,
	int userDataCount,
	EventProvider.EventData* userData)

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

[jkotas]

System.Guid is mostly read-only, but it is non-trivial to mark it as read-only.

#1718 and #1809 are related / duplicates.

I do not see legitimate issue here.

[danmoseley]

Thanks for opening.