-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure: System.Text.Json.Serialization.Tests.ConstructorTests_Stream.PathForChildDictionaryFails #39055
Comments
This appears to be a short-lived bug/failure that occurred just once. Please reopen if it fails again. |
Note, this is on .NET Framework net48-windows-Release-x86-Windows.10.Amd64.Client19H1.Open |
It's happening about twice a week, always on .NET Framework. TestResults
| join kind=inner WorkItems on WorkItemId
| join kind=inner Jobs on JobId
| where Result == "Fail"
| where Method == "PathForChildDictionaryFails"
| where Branch !startswith "refs/pull"
| project
Branch,
Pipeline = tostring(parse_json(Properties).DefinitionName),
Pipeline_Configuration = tostring(parse_json(Properties).configuration),
Phase = tostring(parse_json(Properties)["System.PhaseName"]),
OS = QueueName,
Arch = tostring(parse_json(Properties).architecture),
Result,Finished,
Duration,
Build = tostring(parse_json(Properties).BuildNumber) , Console_log = Message, StackTrace
|
Another hit. (.NET Framework) https://github.com/dotnet/runtime/pull/57301/checks?check_run_id=3315292803 |
@jaredpar I tried to make this a runfo tracking issue but something isn't complying. Can you please take a look? https://runfo.azurewebsites.net/tracking/issue/155/ |
Seems to happen more frequently now. Let's disable the test asap. |
@layomia can you please take a look (if possible today) and if nothing stands out disable the test? |
@ViktorHofer tracking issue created and linked to this one https://runfo.azurewebsites.net/tracking/issue/156/ |
Thanks Jared. Any idea why my tracking issue didn't work? https://runfo.azurewebsites.net/tracking/issue/155/ |
By default the tracking issues only populate the initial data set with the last one day of data. Most of the failures were before that. In my issue I just went to the bottom and told it to look back for four days worth of data. |
I've been hitting that a few of times on my local machine (when running all tests from the command line). |
Although this issue appears low-priority and thus a 7.0 candidate, it appears related to threading it should be investigated for 6.0. |
@steveharter if this should be investigated, should this issue remain open or is there another one? Also, do you have high confidence this is a test issue only? If not, I see it's exclusively on .NET Framework, but either we're safe or we're not, and if we're not then there will be some customer configuration or scenario where it starts to happen. I wonder whether it would be good to investigate far enough to give us confidence we don't need to find a fix. cc @stephentoub for thoughts. |
Updated results -- still all .NET 4.8
|
@danmoseley I believe this is a product bug that got fixed in #57681 for .NET 7 and the test has been disabled for release/6.0 in #57834. Looking at the test history it seems like failures stopped occurring at either branch after each respective PR got merged: let jobs = Jobs
| where Queued > ago (15d)
| where Source startswith "ci/public/dotnet/runtime"
| project Name, Queued, Source;
let failures =
TestResults
| where Result == "Fail"
| where Method == "PathForChildDictionaryFails"
| join jobs on $left.JobName == $right.Name;
let min_t = toscalar(failures | summarize min(Queued));
let max_t = toscalar(failures | summarize max(Queued));
failures
| make-series num=count() on Queued in range(min_t, max_t, 1d) by Source
| limit 5
| render timechart So I think we can close this issue. |
Thanks @eiriktsarpalis for the data. I intended to close this once the 6.0 test was disabled via #57834 got merged. |
failed in job: runtime 20200709.94
Error message
Runfo Tracking Issue: Json PathForChildDictionaryFails
Build Result Summary
The text was updated successfully, but these errors were encountered: