Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NonRandomizedStringEqualityComparer in HashSet #37111

Closed
danmoseley opened this issue May 28, 2020 · 1 comment · Fixed by #37180
Closed

Use NonRandomizedStringEqualityComparer in HashSet #37111

danmoseley opened this issue May 28, 2020 · 1 comment · Fixed by #37180
Assignees
@stephentoub
Labels
area-System.Collections

Comments

@danmoseley
Copy link
Member

This has been pointed out a few times most recently by @GrabYourPitchforks #1989 (comment)

It adds a bit of complexity, but HashSet<string> is common.

Note we would want the #36252 goodness as well.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Collections untriaged New issue has not been triaged by the area owner labels May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

@stephentoub stephentoub self-assigned this May 28, 2020
@stephentoub stephentoub mentioned this issue May 29, 2020
Merged
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite HashSet<T>'s implementation based on Dictionary<T>'s stephentoub/runtime
4 participants
@stephentoub @eiriktsarpalis @danmoseley @Dotnet-GitSync-Bot