Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling EventPipe session doesn't unset runtime providers #36728

Closed
sywhang opened this issue May 19, 2020 · 2 comments · Fixed by #36733
Closed

Disabling EventPipe session doesn't unset runtime providers #36728

sywhang opened this issue May 19, 2020 · 2 comments · Fixed by #36733
Assignees
Milestone

Comments

@sywhang
Copy link
Contributor

sywhang commented May 19, 2020

Initially reported through https://twitter.com/KooKiz/status/1262370490880057344.

When you start a dotnet-trace session (or any EventPipe session with rundown enabled), the runtime will start firing verbose events across the runtime.

I've finished root-causing this issue and will follow-up with a PR to fix this issue soon.

@sywhang sywhang added this to the 5.0 milestone May 19, 2020
@sywhang sywhang self-assigned this May 19, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 19, 2020
@sywhang sywhang removed the untriaged New issue has not been triaged by the area owner label May 20, 2020
@noahfalk
Copy link
Member

When you start a dotnet-trace session (or any EventPipe session with rundown enabled), the runtime will start firing verbose events across the runtime

To ensure I understand it I want to clarify a few things:

  1. Based on the fix my assumption is that 'firing' in this context means the runtime executed some code that created the event arguments and called into EventPipe::WriteEvent(). It does not appear that any of these events are being emitted into in-memory buffers or into an on-disk file because EventPipe::WriteEventInternal() would still correctly filter out the events.
  2. I don't see anything in the code that limits this bug to only occurring when rundown is enabled. If it does require rundown it would be helpful to explain how rundown alters the results.

I've finished root-causing this issue

It can be useful to explain what you found when root causing : ) I think I was able to connect the dots but for anyone not already fairly familiar it would probably be tricky.

@noahfalk
Copy link
Member

I believe bug #36913 would have very similar symptoms to this issue and potentially exacerbated the problem observed here.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants