Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back Win7 and Win8 queues to PRs once we have enough machines #35689

Closed
safern opened this issue May 1, 2020 · 6 comments · Fixed by #38947
Closed

Bring back Win7 and Win8 queues to PRs once we have enough machines #35689

safern opened this issue May 1, 2020 · 6 comments · Fixed by #38947
Assignees
@safern
Labels
area-Infrastructure-libraries
Milestone
5.0.0

Comments

@safern
Copy link
Member

safern commented May 1, 2020

Currently these queues were intentionally reduced. Once we have more cores we should bring them back to PR. Probably we could balance them out anyway as we do many runs on them.

cc: @dotnet/runtime-infrastructure
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 1, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. Please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented May 1, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member Author

safern commented May 1, 2020

PR moving them to CI is: #35690

@ViktorHofer
Copy link
Member

@safern which queues are still disabled?

@ViktorHofer ViktorHofer added this to the 5.0.0 milestone Jul 8, 2020
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2020
@safern
Copy link
Member Author

safern commented Jul 8, 2020

We still have: https://github.com/dotnet/runtime/blob/master/eng/pipelines/libraries/helix-queues-setup.yml#L93 but I think we can remove those as I think the current balancing gives us good coverage without stressing the queues. I'll put up a PR to clean that up and close this issue.

@safern safern self-assigned this Jul 8, 2020
@ViktorHofer
Copy link
Member

Thanks :)

@safern safern mentioned this issue Jul 8, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@safern safern

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Remove commented libraries windows helix queues safern/runtime
3 participants
@ViktorHofer @safern @Dotnet-GitSync-Bot