Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Runtime.Serialization.Formatters.Tests.FormatterServicesTests.GetUninitializedObject_SharedGenericInstance_NetCore_ThrowsNotSupportedException #32183

Closed
ViktorHofer opened this issue Feb 12, 2020 · 3 comments
Labels
area-System.Runtime disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 12, 2020

https://dev.azure.com/dnceng/public/_build/results?buildId=517643&view=ms.vss-test-web.build-test-results-tab&runId=16377280&paneView=attachments&resultId=169118

Configurations:

  • netcoreapp5.0-Linux-Debug-x64-Mono_release-Centos.7.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-SLES.15.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-Ubuntu.1804.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-(Fedora.29.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-29-helix-a12566d-20191210224553
Assert.NotNull() Failure
at System.Runtime.Serialization.Formatters.Tests.FormatterServicesTests.GetUninitializedObject_SharedGenericInstance_NetCore_ThrowsNotSupportedException() in /_/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs:line 156
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 339

cc @stephentoub @GrabYourPitchforks @ViktorHofer

@ViktorHofer
Copy link
Member Author

Ok that only breaks in #32115 because of infra changes (removal of Mono TFM) cc @akoeplinger

@GrabYourPitchforks
Copy link
Member

We could change the test such that it early-exits (with success) if System.__Canon is unavailable.

@akoeplinger akoeplinger added disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime and removed untriaged New issue has not been triaged by the area owner labels Feb 12, 2020
@akoeplinger
Copy link
Member

akoeplinger commented Feb 12, 2020

@GrabYourPitchforks I don't think that would improve the test since we'd still pretty much skip it on Mono and CoreCLR could silently fail if for some reason __Canon returns null there.

I think it's fine to keep the test disabled on Mono given the implementation difference so closing the issue.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime
Projects
None yet
Development

No branches or pull requests

4 participants