Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support W3C format in System.Net for distributed trace context propagation #26464

Closed
SergeyKanzhelev opened this issue Jun 12, 2018 · 3 comments
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@SergeyKanzhelev
Copy link

Motivation

Support extraction and injection of distributed tracing context in a format of W3C headers for System.Net alongside Request-Id.

This issue depends on tracestate collecton implementation in Activity class.

CC: @seth-capistron, @vancem, @jacpull, @lmolkova, @glennc, @davidfowl

@karelz
Copy link
Member

karelz commented Jun 12, 2018

@SergeyKanzhelev what do you expect will need to happen in System.Net for that? New APIs?

@lmolkova
Copy link

lmolkova commented Jun 13, 2018

@karelz

@SergeyKanzhelev means (correct me if I'm wrong) that HttpClient diagnostics instrumentation should be changed to support new standard:

https://github.com/dotnet/corefx/blob/master/src/System.Net.Http/src/System/Net/Http/DiagnosticsHandler.cs#L82

It should not involve any new APIs creation.

@davidsh
Copy link
Contributor

davidsh commented Mar 15, 2019

These PRs dotnet/corefx#35880, dotnet/corefx#35882 address this issue.

cc: @lmolkova

@davidsh davidsh closed this as completed Mar 15, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

5 participants