[arm32] corefx Microsoft.Win32.Registry.Tests failure in CI

[danmoseley]

@BruceForstall commented on Wed Apr 04 2018

All arm32 corefx test jobs are failing Microsoft.Win32.Registry.Tests with:

C:\Users\robox\j\workspace\arm_cross_che---eb7b805d\_\fx\bin\tests\Microsoft.Win32.Registry.Tests\netcoreapp-Windows_NT-Release-arm>call C:\Users\robox\j\workspace\arm_cross_che---eb7b805d\_\fx\bin\testhost\netcoreapp-Windows_NT-Release-arm\dotnet.exe xunit.console.netcore.exe Microsoft.Win32.Registry.Tests.dll  -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonwindowstests  -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
xUnit.net console test runner (32-bit .NET Core)
Copyright (C) 2014 Outercurve Foundation.

Discovering: Microsoft.Win32.Registry.Tests
Discovered:  Microsoft.Win32.Registry.Tests
Starting:    Microsoft.Win32.Registry.Tests
   Microsoft.Win32.RegistryTests.Registry_SetValue_str_str_obj.SetValueWithEnvironmentVariable(valueName: \"ExpandedTest_45\", envVariableName: \"ProgramFiles\", expectedVariableValue: \"C:\\\\Program Files (Arm)\") [FAIL]
      Assert.Equal() Failure
                                  � (pos 18)
      Expected: C:\Program Files (Arm)
      Actual:   C:\Program Files (x86)
                                  � (pos 18)
      Stack Trace:
         D:\j\workspace\arm_cross_che---99792267\_\fx\src\Microsoft.Win32.Registry\tests\Registry\Registry_SetValue_str_str_obj.cs(119,0): at Microsoft.Win32.RegistryTests.Registry_SetValue_str_str_obj.SetValueWithEnvironmentVariable(String valueName, String envVariableName, String expectedVariableValue)
   Microsoft.Win32.RegistryTests.RegistryKey_SetValue_str_obj.SetValueWithEnvironmentVariable(valueName: \"ExpandedTest_45\", envVariableName: \"ProgramFiles\", expectedVariableValue: \"C:\\\\Program Files (Arm)\") [FAIL]
      Assert.Equal() Failure
                                  � (pos 18)
      Expected: C:\Program Files (Arm)
      Actual:   C:\Program Files (x86)
                                  � (pos 18)
      Stack Trace:
         D:\j\workspace\arm_cross_che---99792267\_\fx\src\Microsoft.Win32.Registry\tests\RegistryKey\RegistryKey_SetValue_str_obj.cs(117,0): at Microsoft.Win32.RegistryTests.RegistryKey_SetValue_str_obj.SetValueWithEnvironmentVariable(String valueName, String envVariableName, String expectedVariableValue)
Finished:    Microsoft.Win32.Registry.Tests

=== TEST EXECUTION SUMMARY ===
   Microsoft.Win32.Registry.Tests  Total: 4925, Errors: 0, Failed: 2, Skipped: 0, Time: 18.351s
----- end 22:27:42.93 ----- exit code 1 ----------------------------------------------------------
COREFX TEST FAILED

https://ci.dot.net/job/dotnet_coreclr/job/master/view/arm/job/jitstress/job/arm_cross_checked_windows_nt_corefx_baseline_tst/8/consoleText

---

@RussKeldorph commented on Thu Apr 05 2018

@danmosemsft Wanna take this to corefx? It looks like a test issue.

[danmoseley]

Suspect a Windows bug? %ProgramFiles% is apparently "C:\Program Files (Arm)" but if you feed it to ::ExpandEnvironmentStrings you get "C:\Program Files (x86)".
@RussKeldorph @jfree is there a way to access an ARM32 machine so we can confirm this and file an OS bug?

[RussKeldorph]

@danmosemsft Yes, will reach out through email.

[danmoseley]

The older builds we have seem to not repro this. So we have to ignore for now.

@Anipik could you please cause these tests to skip when envVariableName=ProgramFiles and RuntimeInformation.OSArchitecture=Architecture.Arm?

[BruceForstall]

@Anipik Is this now fixed (and can be closed)?

[Anipik]

@BruceForstall ywah the tests are disabled for now

[BruceForstall]

@Anipik It looks like the test still fails:
https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/arm_cross_checked_windows_nt_corefx_baseline_tst_prtest/12/consoleText

Running: C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\tests\Microsoft.Win32.Registry.Tests\netcoreapp-Windows_NT-Release-arm\RunTests.cmd C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\testhost\netcoreapp-Windows_NT-Release-arm
Using C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\testhost\netcoreapp-Windows_NT-Release-arm as the test runtime folder.
Executing in C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\tests\Microsoft.Win32.Registry.Tests\netcoreapp-Windows_NT-Release-arm\ 
----- start 23:50:24.34 ===============  To repro directly: ===================================================== 
pushd C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\tests\Microsoft.Win32.Registry.Tests\netcoreapp-Windows_NT-Release-arm\
call C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\testhost\netcoreapp-Windows_NT-Release-arm\dotnet.exe xunit.console.netcore.exe Microsoft.Win32.Registry.Tests.dll  -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonwindowstests  -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
popd
===========================================================================================================

C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\tests\Microsoft.Win32.Registry.Tests\netcoreapp-Windows_NT-Release-arm>call C:\Users\robox\j\workspace\arm_cross_che---3f19d0ce\_\fx\bin\testhost\netcoreapp-Windows_NT-Release-arm\dotnet.exe xunit.console.netcore.exe Microsoft.Win32.Registry.Tests.dll  -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonwindowstests  -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
xUnit.net console test runner (32-bit .NET Core)
Copyright (C) 2014 Outercurve Foundation.

Discovering: Microsoft.Win32.Registry.Tests
Discovered:  Microsoft.Win32.Registry.Tests
Starting:    Microsoft.Win32.Registry.Tests
   Microsoft.Win32.RegistryTests.RegistryKey_SetValue_str_obj.SetValueWithEnvironmentVariable(valueName: \"ExpandedTest_89\", envVariableName: \"ProgramFiles\", expectedVariableValue: \"C:\\\\Program Files (Arm)\") [FAIL]
      Assert.Equal() Failure
                                  � (pos 18)
      Expected: C:\Program Files (Arm)
      Actual:   C:\Program Files (x86)
                                  � (pos 18)
      Stack Trace:
         D:\j\workspace\arm_cross_che---69af0b0d\_\fx\src\Microsoft.Win32.Registry\tests\RegistryKey\RegistryKey_SetValue_str_obj.cs(117,0): at Microsoft.Win32.RegistryTests.RegistryKey_SetValue_str_obj.SetValueWithEnvironmentVariable(String valueName, String envVariableName, String expectedVariableValue)
Finished:    Microsoft.Win32.Registry.Tests

=== TEST EXECUTION SUMMARY ===
   Microsoft.Win32.Registry.Tests  Total: 4970, Errors: 0, Failed: 1, Skipped: 0, Time: 17.926s
----- end 23:50:49.32 ----- exit code 1 ----------------------------------------------------------
COREFX TEST FAILED

[danmoseley]

@Anipik missed a test. I will fix this.