[Netfx bug] CustomValidationAttribute doesn't properly implement RequiresValidationContext

[hughbe]

Requested by @ajcvickers. We should mark this as netfx-port-consider and close this issue.

See dotnet/corefx#5203, which fixed this.

public class CustomValidator
{
    public static ValidationResult CorrectValidationMethodOneArg(object o) => ValidationResult.Success;
    public static ValidationResult CorrectValidationMethodOneArgStronglyTyped(string s) => ValidationResult.Success;
    public static ValidationResult CorrectValidationMethodTwoArgs(object o, ValidationContext context) => ValidationResult.Success;
    public static ValidationResult CorrectValidationMethodTwoArgsStronglyTyped(TestClass tc, ValidationContext context) => ValidationResult.Success;
}


[Theory]
[InlineData(nameof(CustomValidator.CorrectValidationMethodOneArg), false)]
[InlineData(nameof(CustomValidator.CorrectValidationMethodOneArgStronglyTyped), false)]
[InlineData(nameof(CustomValidator.CorrectValidationMethodTwoArgs), true)]
[InlineData(nameof(CustomValidator.CorrectValidationMethodTwoArgsStronglyTyped), true)]
public static void RequiresValidationContext_Get_ReturnsExpected(string method, bool expected)
{
    CustomValidationAttribute attribute = new CustomValidationAttribute(typeof(CustomValidator), method);

    // The full .NET framework has a bug where CustomValidationAttribute doesn't
    // validate the context. See https://github.com/dotnet/corefx/pull/5203.
    if (PlatformDetection.IsFullFramework)
    {
        Assert.False(attribute.RequiresValidationContext);
    }
    else
    {
        Assert.Equal(expected, attribute.RequiresValidationContext);
    }
}

[karelz]

The PR dotnet/corefx#5203 was already marked as netfx-port-consider. Here's more information, so following @hughbe's instructions. (Thanks @hughbe!)

[divega]

@karelz could you please confirm that what the process is for netfx-port-consider? Is including the label on an already merged PR usually enough?

[karelz]

@AlexGhiondea created the tool and will likely oversee future .NET Framework porting effort (at least from auditing perspective) - I let him answer.
I am inclined to think that PR with the label should be enough ...

cc @danmosemsft

[AlexGhiondea]

@divega yes -- the tool should pick up the issue even if closed.