Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back asserts to catch unintentional use of generic SpanHelpers overloads #1767

Open
jkotas opened this issue Jan 15, 2020 · 1 comment
Open
Labels
area-System.Memory help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@jkotas
Copy link
Member

jkotas commented Jan 15, 2020

  1. Revert Partial Revert "Add asserts to catch unintentional use of generic overloads (#1200)" #1628
  2. Add fixes as necessary to fix the discovered issues. Relax some asserts in SpanHelpers.T.cs #1472 has some of them.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 15, 2020
@safern
Copy link
Member

safern commented Jan 16, 2020

We now have the right coverage in PRs in order to be able to do this as #1473 is now merged.

@GrabYourPitchforks GrabYourPitchforks added this to the 5.0 milestone Feb 21, 2020
@GrabYourPitchforks GrabYourPitchforks removed the untriaged New issue has not been triaged by the area owner label Feb 21, 2020
@adamsitnik adamsitnik added the help wanted [up-for-grabs] Good issue for external contributors label Jul 6, 2020
@adamsitnik adamsitnik modified the milestones: 5.0.0, Future Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Memory help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

5 participants