Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use live IL.SDK (ILASM and ILDASM) in libraries to build .ilproj's #1137

Closed
safern opened this issue Dec 23, 2019 · 3 comments
Closed

Use live IL.SDK (ILASM and ILDASM) in libraries to build .ilproj's #1137

safern opened this issue Dec 23, 2019 · 3 comments
Labels
area-Infrastructure-libraries

Comments

@safern
Copy link
Member

safern commented Dec 23, 2019

We should be using live IL.SDK and tools for libraries instead of still downloading the SDK in Tools.props and using that.

We could instead of making it an SDK project, import the targets directly from coreclr folder and also resolve ilasm/ildasm from the locally built coreclr outputs.

cc: @dotnet/runtime-infrastructure @danmosemsft
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-ILTools-coreclr untriaged New issue has not been triaged by the area owner labels Dec 23, 2019
@safern safern added area-Infrastructure-libraries and removed area-ILTools-coreclr untriaged New issue has not been triaged by the area owner labels Dec 23, 2019
@ViktorHofer
Copy link
Member

I noticed that even coreclr is using a cached version of the IL SDK when I prepared it for the repo consolidation. We should eliminate all usages of the cached version.

@jkoritzinsky jkoritzinsky mentioned this issue Jan 16, 2020
Closed
@ViktorHofer ViktorHofer mentioned this issue Feb 21, 2020
Closed
@jkotas
Copy link
Member

jkotas commented Feb 21, 2020

I do not think it make sense to use the live version of ilasm/ildasm. It creates a problem for cross-compilation as noted in #32662 among other things. It is fine for the compilers to come from package.

@ViktorHofer
Copy link
Member

@jkotas sounds like you don't want us to do this? Should we close the issue then?

@jkotas jkotas closed this as completed Apr 17, 2020
@safern safern mentioned this issue Jun 16, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jkotas @ViktorHofer @safern @Dotnet-GitSync-Bot