Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] document TypeValidation and MethodValidation #109425

Open
Tracked by #108553
lambdageek opened this issue Oct 31, 2024 · 1 comment
Open
Tracked by #108553

[cdac] document TypeValidation and MethodValidation #109425

lambdageek opened this issue Oct 31, 2024 · 1 comment
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone
10.0.0

Comments

@lambdageek
Copy link
Member

lambdageek commented Oct 31, 2024 •
edited
Loading

The implementations of RuntimeTypeSystem_1 GetTypeHandle and GetMethodHandle perform validation (implemented in the TypeValidation and MethodValidation classes in the cDAC reader) on their input parameters.

While this is not part of the contract, it is an important part of the implementation and we should capture what the validation is doing.

In particular the SOS !U command sometimes passes IP addresses for the methodDesc argument to the ISOSDacInterface::GetMethodDescData method and relies on validation to return an error code
@lambdageek lambdageek mentioned this issue Oct 31, 2024
Open
32 tasks
@lambdageek lambdageek changed the title document TypeValidation and MethodValidation [cdac] document TypeValidation and MethodValidation Oct 31, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 31, 2024
@lambdageek lambdageek added area-Diagnostics-coreclr and removed area-System.ComponentModel.DataAnnotations untriaged New issue has not been triaged by the area owner labels Oct 31, 2024
@lambdageek lambdageek added this to the 10.0.0 milestone Oct 31, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@lambdageek lambdageek mentioned this issue Oct 31, 2024
Merged
@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
2 participants
@lambdageek @tommcdon