Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime repo signing is broken inside the VMR #109178

Closed
ViktorHofer opened this issue Oct 24, 2024 · 3 comments · Fixed by #109206
Closed

Runtime repo signing is broken inside the VMR #109178

ViktorHofer opened this issue Oct 24, 2024 · 3 comments · Fixed by #109206
Assignees
@jkoritzinsky
Labels
area-Infrastructure in-pr There is an active PR which will close this issue when it is merged

Comments

@ViktorHofer
Copy link
Member 


    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/366/ref/net10.0/System.Threading.Tasks.Extensions.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/726/runtimes/android-arm64/lib/net10.0/System.Threading.Tasks.Parallel.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/727/runtimes/android-arm64/lib/net10.0/System.Threading.Thread.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/728/runtimes/android-arm64/lib/net10.0/System.Threading.ThreadPool.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/370/ref/net10.0/System.Threading.Timer.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/371/ref/net10.0/System.Transactions.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/729/runtimes/android-arm64/lib/net10.0/System.Transactions.Local.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/373/ref/net10.0/System.ValueTuple.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/374/ref/net10.0/System.Web.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/730/runtimes/android-arm64/lib/net10.0/System.Web.HttpUtility.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/376/ref/net10.0/System.Windows.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/377/ref/net10.0/System.Xml.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/378/ref/net10.0/System.Xml.Linq.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/731/runtimes/android-arm64/lib/net10.0/System.Xml.ReaderWriter.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/380/ref/net10.0/System.Xml.Serialization.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/732/runtimes/android-arm64/lib/net10.0/System.Xml.XDocument.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/382/ref/net10.0/System.Xml.XmlDocument.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/733/runtimes/android-arm64/lib/net10.0/System.Xml.XmlSerializer.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/734/runtimes/android-arm64/lib/net10.0/System.Xml.XPath.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/735/runtimes/android-arm64/lib/net10.0/System.Xml.XPath.XDocument.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/386/ref/net10.0/WindowsBase.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Container /vmr/src/runtime/artifacts/packages/Release/Shipping/runtime.android-arm64.runtime.native.System.IO.Ports.10.0.0-alpha.1.24523.5.nupkg does not have signature marker.
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/19/tasks/net9.0/AndroidAppBuilder.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/19/tasks/net9.0/AndroidAppBuilder.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/36/tasks/net472/LibraryBuilder.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/37/tasks/net472/MobileBuildTasks.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/38/tasks/net9.0/LibraryBuilder.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/39/tasks/net9.0/MobileBuildTasks.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/47/tasks/net472/MonoAOTCompiler.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/49/tasks/net9.0/MonoAOTCompiler.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/59/tasks/net472/AssemblyStripper.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/60/tasks/net472/MonoTargetsTasks.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/61/tasks/net9.0/AssemblyStripper.dll is NOT signed properly
    /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj(83,5): error : Assembly /vmr/src/runtime/artifacts/tmp/Release/ContainerSigning/62/tasks/net9.0/MonoTargetsTasks.dll is NOT signed properly
        0 Warning(s)
        1205 Error(s)

Noticed in dotnet/sdk#44014

I'm disabling signing in the VMR temporarily to unblock the ingestion PR.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 24, 2024
@ViktorHofer ViktorHofer mentioned this issue Oct 24, 2024
Merged
@vcsjones vcsjones added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky
Copy link
Member

Looking at the signing logs, it looks like the wixpacks are missing, so the exes and msis can't be unwrapped. I'll figure out why they aren't provided.

@jkoritzinsky
Copy link
Member

It's not the wixpacks. It looks like runtime is doing dry-run signing but checking for real signing.

I believe this is the problem because the correct files are being passed to the MicroBuild signing rounds, MicroBuild is doing nothing, the containers are correctly re-packed, and then the validation fails at the end.

@jkoritzinsky jkoritzinsky mentioned this issue Oct 24, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Oct 24, 2024
@jkoritzinsky jkoritzinsky moved this to In Progress in .NET Unified Build Oct 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Oct 25, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Oct 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure in-pr There is an active PR which will close this issue when it is merged
Projects
.NET Unified Build
Status: Done
Runtime Infra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward the ForceDryRunSigning variable down to the runtime inner build jkoritzinsky/runtime
3 participants
@vcsjones @jkoritzinsky @ViktorHofer