Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arcade -sign functionality in runtime #108605

Closed
Tracked by #3708
mmitche opened this issue Oct 7, 2024 · 2 comments · Fixed by #108908
Closed
Tracked by #3708

Enable arcade -sign functionality in runtime #108605

mmitche opened this issue Oct 7, 2024 · 2 comments · Fixed by #108908
Assignees
Labels
area-Infrastructure in-pr There is an active PR which will close this issue when it is merged

Comments

@mmitche
Copy link
Member

mmitche commented Oct 7, 2024

Right now runtime uses a bit of custom infra to sign (a separate job that gathers intermediate artifacts and signs them). For the VMR, it also needs to support the ability to do the traditional arcade-based signing. When -sign is passed, Sign.proj is invoked, items to sign is populated, etc. etc.

@mmitche mmitche converted this from a draft issue Oct 7, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 7, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 7, 2024
@vcsjones vcsjones added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 7, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky self-assigned this Oct 8, 2024
@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 15, 2024

@jkoritzinsky please see my PR #100004 which does a lot of what we want here. We don't need the PostBuildSign & SignAndPublishAsJoinPoint stuff in it anymore now, but everything else uses the Arcade integration.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in .NET Unified Build Oct 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Oct 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure in-pr There is an active PR which will close this issue when it is merged
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants