Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Implement GetPEFileBase #108450

Closed
Tracked by #108553
lambdageek opened this issue Oct 1, 2024 · 4 comments
Closed
Tracked by #108553

[cdac] Implement GetPEFileBase #108450

lambdageek opened this issue Oct 1, 2024 · 4 comments
Assignees
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@lambdageek
Copy link
Member

For the "clrma" APIs, we need to implement the ISOSDacInterface::GetPEFileBase DAC API

The brittle DAC version is here:

ClrDataAccess::GetPEFileBase(CLRDATA_ADDRESS moduleAddr, CLRDATA_ADDRESS *base)
{
if (moduleAddr == 0 || base == NULL)
return E_INVALIDARG;
SOSDacEnter();
PTR_Module pModule = PTR_Module(TO_TADDR(moduleAddr));
// More fields later?
if (!pModule->IsReflectionEmit())
{
*base = TO_CDADDR(dac_cast<TADDR>(pModule->m_baseAddress));
}
else
{
*base = (CLRDATA_ADDRESS)NULL;
}
SOSDacLeave();
return hr;
}

Part of #99298

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 1, 2024
@lambdageek lambdageek removed the untriaged New issue has not been triaged by the area owner label Oct 1, 2024
@lambdageek lambdageek added this to the 10.0.0 milestone Oct 1, 2024
@lambdageek
Copy link
Member Author

/cc @steveisok

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@lambdageek
Copy link
Member Author

This will be very similar to #106358

@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Oct 7, 2024
max-charlamb added a commit that referenced this issue Oct 8, 2024
Implements ISOSDacInterface::GetPEFileBase in cDAC

Module already contains the Base so no change is needed.
Loader_1.cs already implements GetILBase to get the Base off of the module.

Contributes to #108450
@max-charlamb
Copy link
Contributor

Implemented in #108602

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

3 participants