Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] HybridGlobalization correct HashCode ranges of skipped unicodes #101912

Closed
ilonatommy opened this issue May 6, 2024 · 2 comments · Fixed by #102912
Closed

[browser] HybridGlobalization correct HashCode ranges of skipped unicodes #101912

ilonatommy opened this issue May 6, 2024 · 2 comments · Fixed by #102912
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@ilonatommy
Copy link
Member

To calculate hashcodes in Hybrid Globalization we have to use invariant methods. We can over-skip characters when creating hashes, this would result in less collisions and impacts performance but not correctness. Because of that, we can choose a subset of chars that we will hash and that give the same hashing result in invariant mode and in ICU mode and skip all the rest.

Draft PR: #97351.
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm labels May 6, 2024
@ilonatommy ilonatommy self-assigned this May 6, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 6, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@lewing lewing added this to the 9.0.0 milestone May 6, 2024
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 6, 2024
@ilonatommy ilonatommy mentioned this issue May 23, 2024
Closed
23 tasks
@ilonatommy ilonatommy mentioned this issue May 31, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[browser] HybridGlobalization correct HashCode ranges of skipped unicodes ilonatommy/runtime
2 participants
@lewing @ilonatommy