Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double check failing allocPgoInstrumentationBySchema EE calls #101711

Closed
jakobbotsch opened this issue Apr 30, 2024 · 3 comments
Closed

Double check failing allocPgoInstrumentationBySchema EE calls #101711

jakobbotsch opened this issue Apr 30, 2024 · 3 comments
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Apr 30, 2024 •
edited
Loading

#101685 revealed that the EE is returning E_NOTIMPL from this function in some cases on macOS. We should double check why this happens.

The compilations where we see this in libraries_tests.run.osx.arm64.Release:

   1: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=146, code size=496, hash=0xbc1ccf13]
   2: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write4_ArrayOfBridgeGameHighScore(System.Object):this [Instrumented Tier0, IL size=148, code size=504, hash=0xe7077814]
   3: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleTypeArray:Write3_ArrayOfSimpleType(System.Object):this [Instrumented Tier0, IL size=141, code size=484, hash=0x280d230e]
   4: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=219, code size=864, hash=0x271bbc41]
   5: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write3_wrapper(System.Object[]):this [Instrumented Tier0, IL size=343, code size=1080, hash=0x525b6243]
   6: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleCDC:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=161, code size=536, hash=0xca4d3c2a]
   7: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyEnumerable1:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=161, code size=536, hash=0x00d495eb]
   8: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=113, code size=456, hash=0x271bbc41]
   9: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterImmutableArray1:Write1_ArrayOfInt(System.Object):this [Instrumented Tier0, IL size=128, code size=460, hash=0xb2f5504c]
  10: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterImmutableArray1:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=125, code size=460, hash=0x86789d92]
  11: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterImmutableList1:Write1_ArrayOfInt(System.Object):this [Instrumented Tier0, IL size=151, code size=516, hash=0x188b7437]
  12: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyEnumerable:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=158, code size=516, hash=0x87ac8d82]
  13: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write2_wrapper(System.Object[]):this [Instrumented Tier0, IL size=396, code size=1292, hash=0xc17fa042]
  14: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=134, code size=544, hash=0x271bbc41]
  15: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=115, code size=472, hash=0x271bbc41]
  16: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleTypeArray:Write3_ArrayOfSimpleType(System.Object):this [Instrumented Tier0, IL size=141, code size=484, hash=0x280d230e]
  17: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyList:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=148, code size=504, hash=0x9f590a2e]
  18: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterInt32Array:Write1_ArrayOfArrayOfInt(System.Object):this [Instrumented Tier0, IL size=225, code size=764, hash=0x5d14c9bd]
  19: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterObjectArray:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=141, code size=484, hash=0x82bd33b4]
  20: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterInt32Array:Write1_ArrayOfArrayOfArrayOfInt(System.Object):this [Instrumented Tier0, IL size=310, code size=1016, hash=0x5d00456d]
  21: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write1_Places(System.Object):this [Instrumented Tier0, IL size=146, code size=496, hash=0x45ffd37e]
  22: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write3_ArrayOfLevelData(System.Object):this [Instrumented Tier0, IL size=148, code size=504, hash=0xd1950bc2]
  23: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyCollection:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=148, code size=500, hash=0xa5ca65ba]
  24: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterEnumerableCollection:Write1_ArrayOfDateTime(System.Object):this [Instrumented Tier0, IL size=171, code size=564, hash=0x09c6d2ec]
  25: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleType:Write3_SimpleType(System.Object):this [Instrumented Tier0, IL size=65, code size=220, hash=0x63d30d07]
  26: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=146, code size=496, hash=0xbc1ccf13]
  27: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterXmlSchema:Write64_schema(System.Object):this [Instrumented Tier0, IL size=65, code size=220, hash=0xa653c66f]
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch jakobbotsch added this to the 9.0.0 milestone Apr 30, 2024
@jakobbotsch jakobbotsch added the Priority:2 Work that is important, but not critical for the release label Apr 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 30, 2024
@jakobbotsch jakobbotsch mentioned this issue Apr 30, 2024
Merged
@kunalspathak
Copy link
Member

@jakobbotsch - do you think you can take this one?

@jakobbotsch
Copy link
Member Author

These failures aren't present anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@jakobbotsch @kunalspathak