Fix test suppression on mobile

dotnet · Sep 22, 2021 · e153b3a · e153b3a
1 parent a07f142
commit e153b3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/libraries/System.Text.RegularExpressions/tests/Regex.Tests.Common.cs b/src/libraries/System.Text.RegularExpressions/tests/Regex.Tests.Common.cs
@@ -53,9 +53,12 @@ public static IEnumerable<RegexEngine> AvailableEngines
             get
             {
                 yield return RegexEngine.Interpreter;
+
                 yield return RegexEngine.Compiled;
+
                 if (PlatformDetection.IsNetCore &&
                     PlatformDetection.IsReflectionEmitSupported && // the source generator doesn't use reflection emit, but it does use Roslyn for the equivalent
+                    PlatformDetection.IsNotMobile &&
                     PlatformDetection.IsNotBrowser)
                 {
                     yield return RegexEngine.SourceGenerated;

diff --git a/...ssions/tests/System.Text.RegularExpressions.Generators.Tests/RegexGeneratorParserTests.cs b/...ssions/tests/System.Text.RegularExpressions.Generators.Tests/RegexGeneratorParserTests.cs
@@ -19,8 +19,7 @@ namespace System.Text.RegularExpressions.Generator.Tests
 {
     // Tests don't actually use reflection emit, but they do generate assembly via Roslyn in-memory at run time and expect it to be JIT'd.
     // The tests also use typeof(object).Assembly.Location, which returns an empty string on wasm.
-    [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
-    [PlatformSpecific(~TestPlatforms.Browser)]
+    [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported), nameof(PlatformDetection.IsNotMobile), nameof(PlatformDetection.IsNotBrowser))]
     public class RegexGeneratorParserTests
     {
         [Fact]