From 8bf55bd2299d4c9c96c506160951fa573bb2c312 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 30 Jul 2021 12:44:10 -0400 Subject: [PATCH] [libraries][Android] Reenable System.Net.Mail.Functional tests --- .../tests/BlockingCollectionCancellationTests.cs | 1 - .../ComponentModel/CategoryAttributeTests.cs | 5 ----- .../InvalidEnumArgumentExceptionTests.cs | 1 - .../Hosting/Core/CompositionDependencyTests.cs | 1 - .../Hosting/Core/ExportDescriptorPromiseTests.cs | 1 - .../Hosting/Core/CompositionContractTests.cs | 1 - .../System.Composition/tests/CardinalityTests.cs | 2 -- .../System.Composition/tests/ContractTests.cs | 1 - .../System.Composition/tests/DiscoveryTests.cs | 3 --- .../tests/ErrorMessageQualityTests.cs | 5 ----- .../tests/MetadataViewGenerationTests.cs | 2 -- .../System.Composition/tests/OpenGenericsTests.cs | 2 -- .../System.Composition/tests/SharingTests.cs | 1 - .../tests/FlushAsyncCompletionTests.cs | 1 - .../System.IO.Pipelines/tests/FlushAsyncTests.cs | 1 - .../tests/PipeReaderWriterFacts.cs | 3 --- .../tests/ReadAsyncCompletionTests.cs | 1 - .../tests/Functional/LoggingTest.cs | 1 - .../tests/Functional/SmtpExceptionTest.cs | 2 -- .../tests/FunctionalTests/LoggingTest.cs | 4 ---- .../tests/FunctionalTests/TelemetryTest.cs | 1 - .../tests/xNodeBuilder/CommonTests.cs | 3 --- .../tests/XmlReader/Tests/ReaderEncodingTests.cs | 7 ------- src/libraries/tests.proj | 15 --------------- 24 files changed, 65 deletions(-) diff --git a/src/libraries/System.Collections.Concurrent/tests/BlockingCollectionCancellationTests.cs b/src/libraries/System.Collections.Concurrent/tests/BlockingCollectionCancellationTests.cs index a3d366927137d..14fa6d8d48746 100644 --- a/src/libraries/System.Collections.Concurrent/tests/BlockingCollectionCancellationTests.cs +++ b/src/libraries/System.Collections.Concurrent/tests/BlockingCollectionCancellationTests.cs @@ -97,7 +97,6 @@ public static void ExternalCancel_Negative() } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50576", TestPlatforms.Android)] public static void ExternalCancel_AddToAny() { for (int test = 0; test < 3; test++) diff --git a/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs b/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs index a14dd422fbd68..5c87bba93b893 100644 --- a/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/CategoryAttributeTests.cs @@ -9,7 +9,6 @@ namespace System.ComponentModel.Tests public class CategoryAttributeTests { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)] public void Ctor_Default() { var attribute = new CategoryAttribute(); @@ -24,7 +23,6 @@ public void Ctor_Default() [InlineData("Misc", true)] [InlineData("misc", false)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, ".NET Framework throws a NullReferenceException")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)] public void Ctor_String(string category, bool expectedIsDefaultAttribute) { var attribute = new CategoryAttribute(category); @@ -61,7 +59,6 @@ public static IEnumerable Equals_TestData() [Theory] [MemberData(nameof(Equals_TestData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)] public void Equals_Object_ReturnsExpected(CategoryAttribute attribute, object other, bool expected) { Assert.Equal(expected, attribute.Equals(other)); @@ -90,7 +87,6 @@ public static IEnumerable Properties_TestData() [Theory] [MemberData(nameof(Properties_TestData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)] public void Properties_Get_ReturnsExpected(Func attributeThunk, string expectedCategory) { CategoryAttribute attribute = attributeThunk(); @@ -129,7 +125,6 @@ public void GetLocalizedString_InvokeValueExists_ReturnsNonEmpty(string value) [InlineData(null)] [InlineData("")] [InlineData("value")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)] public void GetLocalizedString_InvokeNoSuchValue_ReturnsNull(string value) { var attribute = new SubCategoryAttribute(); diff --git a/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/InvalidEnumArgumentExceptionTests.cs b/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/InvalidEnumArgumentExceptionTests.cs index a993c3f81d676..4b6187edc248d 100644 --- a/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/InvalidEnumArgumentExceptionTests.cs +++ b/src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/InvalidEnumArgumentExceptionTests.cs @@ -88,7 +88,6 @@ public void Ctor_NullEnumClass_ThrowsArgumentNulException() } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)] public void Ctor_SerializationInfo_StreamingContext() { using (var stream = new MemoryStream()) diff --git a/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionDependencyTests.cs b/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionDependencyTests.cs index cfa0fc3fc2708..eb9fb2192704d 100644 --- a/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionDependencyTests.cs +++ b/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionDependencyTests.cs @@ -37,7 +37,6 @@ public void Missing_NullSite_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50917", TestPlatforms.Android)] public void Satisfied_Invoke_ReturnsExpected() { var contract = new CompositionContract(typeof(int)); diff --git a/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/ExportDescriptorPromiseTests.cs b/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/ExportDescriptorPromiseTests.cs index 2883082f94a70..082eca388e478 100644 --- a/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/ExportDescriptorPromiseTests.cs +++ b/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/ExportDescriptorPromiseTests.cs @@ -252,7 +252,6 @@ public void GetDescriptor_CycleMetadataBroken_HasExpectedProperties() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50917", TestPlatforms.Android)] public void ToString_Invoke_ReturnsExpected() { var promise = new ExportDescriptorPromise(new CompositionContract(typeof(int)), "Origin", true, () => Enumerable.Empty(), depdendencies => diff --git a/src/libraries/System.Composition.Runtime/tests/System/Composition/Hosting/Core/CompositionContractTests.cs b/src/libraries/System.Composition.Runtime/tests/System/Composition/Hosting/Core/CompositionContractTests.cs index 04088a747177c..7784bad7ba48f 100644 --- a/src/libraries/System.Composition.Runtime/tests/System/Composition/Hosting/Core/CompositionContractTests.cs +++ b/src/libraries/System.Composition.Runtime/tests/System/Composition/Hosting/Core/CompositionContractTests.cs @@ -279,7 +279,6 @@ public static IEnumerable ToString_TestData() [Theory] [MemberData(nameof(ToString_TestData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50918", TestPlatforms.Android)] public void ToString_Get_ReturnsExpected(CompositionContract contract, string expected) { Assert.Equal(expected, contract.ToString()); diff --git a/src/libraries/System.Composition/tests/CardinalityTests.cs b/src/libraries/System.Composition/tests/CardinalityTests.cs index 87723ebf69acb..149287cfa8721 100644 --- a/src/libraries/System.Composition/tests/CardinalityTests.cs +++ b/src/libraries/System.Composition/tests/CardinalityTests.cs @@ -31,7 +31,6 @@ public UsesLog(ILog log) { } } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void RequestingOneWhereMultipleArePresentFails() { var c = CreateContainer(typeof(LogA), typeof(LogB)); @@ -42,7 +41,6 @@ public void RequestingOneWhereMultipleArePresentFails() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void ImportingOneWhereMultipleArePresentFails() { var c = CreateContainer(typeof(LogA), typeof(LogB), typeof(UsesLog)); diff --git a/src/libraries/System.Composition/tests/ContractTests.cs b/src/libraries/System.Composition/tests/ContractTests.cs index b0c3fbc46f631..746cd56641f37 100644 --- a/src/libraries/System.Composition/tests/ContractTests.cs +++ b/src/libraries/System.Composition/tests/ContractTests.cs @@ -67,7 +67,6 @@ public void ConstraintsWithEquivalentKeysAndValuesHaveTheSameHashCode() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void FormattingTheContractPrintsConstraintKeysAndValues() { var mcd = new CompositionContract(typeof(AType), null, new Dictionary { { "A", 1 }, { "B", "C" } }); diff --git a/src/libraries/System.Composition/tests/DiscoveryTests.cs b/src/libraries/System.Composition/tests/DiscoveryTests.cs index 8087e3d938436..833001774e4e0 100644 --- a/src/libraries/System.Composition/tests/DiscoveryTests.cs +++ b/src/libraries/System.Composition/tests/DiscoveryTests.cs @@ -56,7 +56,6 @@ public void DiscoversCustomExportAttributesUnderConventions() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void InstanceExportsOfIncompatibleContractsAreDetected() { var x = Assert.Throws(() => CreateContainer(typeof(IncompatibleRule))); @@ -64,7 +63,6 @@ public void InstanceExportsOfIncompatibleContractsAreDetected() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void PropertyExportsOfIncompatibleContractsAreDetected() { var x = Assert.Throws(() => CreateContainer(typeof(IncompatibleRuleProperty))); @@ -124,7 +122,6 @@ public class MultipleImportsOnProperty } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void MultipleImportAttributesAreDetected() { var c = new ContainerConfiguration() diff --git a/src/libraries/System.Composition/tests/ErrorMessageQualityTests.cs b/src/libraries/System.Composition/tests/ErrorMessageQualityTests.cs index f53e79612eb10..f0918e392c29c 100644 --- a/src/libraries/System.Composition/tests/ErrorMessageQualityTests.cs +++ b/src/libraries/System.Composition/tests/ErrorMessageQualityTests.cs @@ -63,7 +63,6 @@ public class RequiresOnlyOne } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void MissingTopLevelExportMessageIsInformative() { var cc = CreateContainer(); @@ -72,7 +71,6 @@ public void MissingTopLevelExportMessageIsInformative() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void MissingTopLevelNamedExportMessageIsInformative() { var cc = CreateContainer(); @@ -81,7 +79,6 @@ public void MissingTopLevelNamedExportMessageIsInformative() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void MissingDependencyMessageIsInformative() { var cc = CreateContainer(typeof(UserOfUnregistered)); @@ -92,7 +89,6 @@ public void MissingDependencyMessageIsInformative() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void CycleMessageIsInformative() { var cc = CreateContainer(typeof(CycleA), typeof(CycleB), typeof(CycleC)); @@ -106,7 +102,6 @@ public void CycleMessageIsInformative() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void CardinalityViolationMessageIsInformative() { var cc = CreateContainer(typeof(ShouldBeOne), typeof(ButThereIsAnother), typeof(RequiresOnlyOne)); diff --git a/src/libraries/System.Composition/tests/MetadataViewGenerationTests.cs b/src/libraries/System.Composition/tests/MetadataViewGenerationTests.cs index e2561e916ee05..9786a7db1ae4f 100644 --- a/src/libraries/System.Composition/tests/MetadataViewGenerationTests.cs +++ b/src/libraries/System.Composition/tests/MetadataViewGenerationTests.cs @@ -77,7 +77,6 @@ public InvalidConcreteView(string unsupported) { } } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void AConcreteTypeWithUnsupportedConstructorsCannotBeUsedAsAMetadataView() { var cc = new ContainerConfiguration() @@ -102,7 +101,6 @@ public class ImportsWithMetadataInterface } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void UnsupportedMetadataViewMessageIsInformative() { var cc = new ContainerConfiguration().WithParts(typeof(ImportsWithMetadataInterface), typeof(ExportsWithMetadata)).CreateContainer(); diff --git a/src/libraries/System.Composition/tests/OpenGenericsTests.cs b/src/libraries/System.Composition/tests/OpenGenericsTests.cs index 8462c5aa6f67f..a7eec57c15b09 100644 --- a/src/libraries/System.Composition/tests/OpenGenericsTests.cs +++ b/src/libraries/System.Composition/tests/OpenGenericsTests.cs @@ -123,7 +123,6 @@ public void MultipleGenericExportsCanBeSpecifiedAtTheClassLevel() // In future, the set of allowable generic type mappings will be expanded (see // ignored tests above). [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void TypesWithMismatchedGenericParameterListsAreDetectedDuringDiscovery() { var x = Assert.Throws(() => CreateContainer(typeof(RepositoryWithKey<,>))); @@ -131,7 +130,6 @@ public void TypesWithMismatchedGenericParameterListsAreDetectedDuringDiscovery() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void TypesWithNonGenericExportsAreDetectedDuringDiscovery() { var x = Assert.Throws(() => CreateContainer(typeof(RepositoryWithNonGenericExport<>))); diff --git a/src/libraries/System.Composition/tests/SharingTests.cs b/src/libraries/System.Composition/tests/SharingTests.cs index 22cd14fa41713..826881f349c5d 100644 --- a/src/libraries/System.Composition/tests/SharingTests.cs +++ b/src/libraries/System.Composition/tests/SharingTests.cs @@ -318,7 +318,6 @@ public class SharingTest : ContainerTests /// we fail only when we create instance of B.. is that correct. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)] public void BoundaryExposedBoundaryButNoneImported() { try diff --git a/src/libraries/System.IO.Pipelines/tests/FlushAsyncCompletionTests.cs b/src/libraries/System.IO.Pipelines/tests/FlushAsyncCompletionTests.cs index 6169d1e05684b..5b56222f819e5 100644 --- a/src/libraries/System.IO.Pipelines/tests/FlushAsyncCompletionTests.cs +++ b/src/libraries/System.IO.Pipelines/tests/FlushAsyncCompletionTests.cs @@ -10,7 +10,6 @@ namespace System.IO.Pipelines.Tests public class FlushAsyncCompletionTests : PipeTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)] public void AwaitingFlushAsyncAwaitableTwiceCompletesReaderWithException() { async Task Await(ValueTask a) diff --git a/src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs b/src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs index fa3db4c91ae4d..afa1f318937a4 100644 --- a/src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs +++ b/src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs @@ -71,7 +71,6 @@ public async Task CallingFlushAsyncMultipleTimesAllowsFirstToComplete() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)] public async Task DoubleFlushAsyncThrows() { Pipe.Writer.WriteEmpty(65); diff --git a/src/libraries/System.IO.Pipelines/tests/PipeReaderWriterFacts.cs b/src/libraries/System.IO.Pipelines/tests/PipeReaderWriterFacts.cs index dc4593bfeb0db..f4b41418a6afc 100644 --- a/src/libraries/System.IO.Pipelines/tests/PipeReaderWriterFacts.cs +++ b/src/libraries/System.IO.Pipelines/tests/PipeReaderWriterFacts.cs @@ -150,7 +150,6 @@ public async Task CompleteReaderAfterFlushWithoutAdvancingDoesNotThrow() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)] public async Task AdvanceAfterCompleteThrows() { await _pipe.Writer.WriteAsync(new byte[1]); @@ -621,7 +620,6 @@ public async Task WritingDataMakesDataReadableViaPipeline() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)] public async Task DoubleAsyncReadThrows() { ValueTask readTask1 = _pipe.Reader.ReadAsync(); @@ -658,7 +656,6 @@ public async Task CompleteAfterAdvanceCommits() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)] public async Task AdvanceWithoutReadThrows() { await _pipe.Writer.WriteAsync(new byte[3]); diff --git a/src/libraries/System.IO.Pipelines/tests/ReadAsyncCompletionTests.cs b/src/libraries/System.IO.Pipelines/tests/ReadAsyncCompletionTests.cs index 2abc58534071c..f15da4024d67e 100644 --- a/src/libraries/System.IO.Pipelines/tests/ReadAsyncCompletionTests.cs +++ b/src/libraries/System.IO.Pipelines/tests/ReadAsyncCompletionTests.cs @@ -9,7 +9,6 @@ namespace System.IO.Pipelines.Tests public class ReadAsyncCompletionTests : PipeTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)] public void AwaitingReadAsyncAwaitableTwiceCompletesWriterWithException() { async Task Await(ValueTask a) diff --git a/src/libraries/System.Net.Mail/tests/Functional/LoggingTest.cs b/src/libraries/System.Net.Mail/tests/Functional/LoggingTest.cs index 95f952e663536..c4c9e801fd78c 100644 --- a/src/libraries/System.Net.Mail/tests/Functional/LoggingTest.cs +++ b/src/libraries/System.Net.Mail/tests/Functional/LoggingTest.cs @@ -13,7 +13,6 @@ namespace System.Net.Mail.Tests public class LoggingTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50999", TestPlatforms.Android)] public void EventSource_ExistsWithCorrectId() { Type esType = typeof(SmtpClient).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false); diff --git a/src/libraries/System.Net.Mail/tests/Functional/SmtpExceptionTest.cs b/src/libraries/System.Net.Mail/tests/Functional/SmtpExceptionTest.cs index a10bed3e1684f..d97d147413cf7 100644 --- a/src/libraries/System.Net.Mail/tests/Functional/SmtpExceptionTest.cs +++ b/src/libraries/System.Net.Mail/tests/Functional/SmtpExceptionTest.cs @@ -54,7 +54,6 @@ public void TestConstructorWithStatusCodeArgument() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50999", TestPlatforms.Android)] public void TestConstructorWithStringArgument() { string msg; @@ -92,7 +91,6 @@ public void TestConstructorWithStringArgument() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50999", TestPlatforms.Android)] public void TestConstructorWithStatusCodeAndStringArgument() { string msg; diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/LoggingTest.cs b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/LoggingTest.cs index e4d4fcc9aa6a4..915067acffbbf 100644 --- a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/LoggingTest.cs +++ b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/LoggingTest.cs @@ -17,7 +17,6 @@ namespace System.Net.NameResolution.Tests public class LoggingTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)] public static void EventSource_ExistsWithCorrectId() { Type esType = typeof(Dns).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false); @@ -30,7 +29,6 @@ public static void EventSource_ExistsWithCorrectId() } [ConditionalFact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)] public void GetHostEntry_InvalidHost_LogsError() { using (var listener = new TestEventListener("Private.InternalDiagnostics.System.Net.NameResolution", EventLevel.Error)) @@ -65,7 +63,6 @@ public void GetHostEntry_InvalidHost_LogsError() } [ConditionalFact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)] public async Task GetHostEntryAsync_InvalidHost_LogsError() { using (var listener = new TestEventListener("Private.InternalDiagnostics.System.Net.NameResolution", EventLevel.Error)) @@ -115,7 +112,6 @@ static async Task WaitForErrorEventAsync(ConcurrentQueue } [ConditionalFact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)] public void GetHostEntry_ValidName_NoErrors() { using (var listener = new TestEventListener("Private.InternalDiagnostics.System.Net.NameResolution", EventLevel.Verbose)) diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs index a3ee6418d903b..55d0e3ac08f36 100644 --- a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs +++ b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs @@ -17,7 +17,6 @@ namespace System.Net.NameResolution.Tests public class TelemetryTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)] public static void EventSource_ExistsWithCorrectId() { Type esType = typeof(Dns).Assembly.GetType("System.Net.NameResolutionTelemetry", throwOnError: true, ignoreCase: false); diff --git a/src/libraries/System.Private.Xml.Linq/tests/xNodeBuilder/CommonTests.cs b/src/libraries/System.Private.Xml.Linq/tests/xNodeBuilder/CommonTests.cs index 86f7320662620..772f9b87ab908 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/xNodeBuilder/CommonTests.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/xNodeBuilder/CommonTests.cs @@ -3403,7 +3403,6 @@ private void CData_4() //[Variation(Id = 5, Desc = "WriteCData with ]]>", Priority = 1)] [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50944", TestPlatforms.Android)] public void WriteCDataWithTwoClosingBrackets_5() { XDocument doc = new XDocument(); @@ -3599,7 +3598,6 @@ private void comment_5() //[Variation(Id = 6, Desc = "WriteComment with -- in value", Priority = 1)] [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50944", TestPlatforms.Android)] public void WriteCommentWithDoubleHyphensInValue() { XDocument doc = new XDocument(); @@ -4205,7 +4203,6 @@ private void pi_10() //[Variation(Id = 11, Desc = "Include PI end tag ?> as part of the text value", Priority = 1)] [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50944", TestPlatforms.Android)] public void IncludePIEndTagAsPartOfTextValue() { XDocument doc = new XDocument(); diff --git a/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs b/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs index c89b48447c37a..0c91c2b2e27b3 100644 --- a/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs @@ -17,7 +17,6 @@ public class ReaderEncodingTests private static string _invalidCharInThisEncoding = "Invalid character in the given encoding"; [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void ReadWithSurrogateCharAndInvalidChar() { // {60, 0, 0, 0} is a normal char, {0, 34, 1, 0} is a surrogate char {62, 100, 60, 47} is an invalid char @@ -30,7 +29,6 @@ public static void ReadWithSurrogateCharAndInvalidChar() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void ReadWithNormalCharAndInvalidChar() { // {60, 0, 0, 0, 65, 0, 0, 0} are normal chars, {62, 100, 60, 47} is an invalid char, similar bytes used below tests @@ -43,7 +41,6 @@ public static void ReadWithNormalCharAndInvalidChar() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void ReadWithSurrogateCharAndInvalidChar_ValidXmlStructure() { var bytes = new byte[] { 60, 0, 0, 0, 97, 0, 0, 0, 62, 0, 0, 0, 0, 34, 1, 0, 62, 100, 60, 47, 60, 0, 0, 0, 47, 0, 0, 0, 97, 0, 0, 0, 62, 0, 0, 0 }; @@ -55,7 +52,6 @@ public static void ReadWithSurrogateCharAndInvalidChar_ValidXmlStructure() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void ReadWithSurrogateCharAsElementName() { var bytes = new byte[] { 60, 0, 0, 0, 0, 34, 1, 0, 65, 0, 0, 0, 97, 0, 0, 0 }; @@ -88,7 +84,6 @@ public static void BytesEndingWithSurrogateChar() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void BytesStartingWithInvalidChar() { var bytes = new byte[] { 62, 100, 60, 47, 60, 0, 0, 0, 0, 34, 1, 0, 65, 0, 0, 0, 97, 0, 0, 0 }; @@ -99,7 +94,6 @@ public static void BytesStartingWithInvalidChar() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void BytesEndingWithInvalidChar() { var bytes = new byte[] { 60, 0, 0, 0, 97, 0, 0, 0, 62, 0, 0, 0, 65, 0, 0, 0, 65, 0, 0, 0, 97, 0, 0, 0, 62, 100, 60, 47}; @@ -120,7 +114,6 @@ public static void ReadWithSurrogateChar_ValidXmlStructure() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)] public static void ReadWithIncompleteBytes() { var bytes = new byte[] { 60, 0, 0, 0, 97, 0, 0, 0, 65, 0, 0, 0, 97, 62, 10}; diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index a151eab3ddbeb..736f1160188ba 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -74,9 +74,6 @@ - - - @@ -86,18 +83,6 @@ - - - - - - - - - - - -