Revert Add to int argument

Cast at call-site to prevent performance degradation.
dotnet · Jun 18, 2024 · 8683434 · 8683434
1 parent cb7004a
commit 8683434
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/Calendar.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/Calendar.cs
@@ -127,7 +127,7 @@ internal static void CheckAddResult(long ticks, DateTime minValue, DateTime maxV
             }
         }
 
-        internal DateTime Add(DateTime time, double value, long scale)
+        internal DateTime Add(DateTime time, double value, int scale)
         {
             // From ECMA CLI spec, Partition III, section 3.27:
             //
@@ -169,7 +169,7 @@ public virtual DateTime AddMilliseconds(DateTime time, double milliseconds)
         /// </summary>
         public virtual DateTime AddDays(DateTime time, int days)
         {
-            return Add(time, days, TimeSpan.MillisecondsPerDay);
+            return Add(time, days, (int)TimeSpan.MillisecondsPerDay);
         }
 
         /// <summary>
@@ -181,7 +181,7 @@ public virtual DateTime AddDays(DateTime time, int days)
         /// </summary>
         public virtual DateTime AddHours(DateTime time, int hours)
         {
-            return Add(time, hours, TimeSpan.MillisecondsPerHour);
+            return Add(time, hours, (int)TimeSpan.MillisecondsPerHour);
         }
 
         /// <summary>
@@ -193,7 +193,7 @@ public virtual DateTime AddHours(DateTime time, int hours)
         /// </summary>
         public virtual DateTime AddMinutes(DateTime time, int minutes)
         {
-            return Add(time, minutes, TimeSpan.MillisecondsPerMinute);
+            return Add(time, minutes, (int)TimeSpan.MillisecondsPerMinute);
         }
 
         /// <summary>
@@ -225,7 +225,7 @@ public virtual DateTime AddMinutes(DateTime time, int minutes)
         /// </summary>
         public virtual DateTime AddSeconds(DateTime time, int seconds)
         {
-            return Add(time, seconds, TimeSpan.MillisecondsPerSecond);
+            return Add(time, seconds, (int)TimeSpan.MillisecondsPerSecond);
         }
 
         // Returns the DateTime resulting from adding a number of