From 7b3cb5e2e66984ac5116e5b779e8a5e3c2a86f54 Mon Sep 17 00:00:00 2001 From: Matt Kotsenas Date: Fri, 17 Jul 2020 16:20:15 -0700 Subject: [PATCH] Revert adding asserts in tests Since the tests run across different printer hardware they can't take a dependency on the default printer settings. Revert adding asserts in these cases so the tests still verify that the properties don't throw. --- .../tests/Printing/PrinterSettingsTests.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libraries/System.Drawing.Common/tests/Printing/PrinterSettingsTests.cs b/src/libraries/System.Drawing.Common/tests/Printing/PrinterSettingsTests.cs index ee924a0db40a0..137ea1d48d31b 100644 --- a/src/libraries/System.Drawing.Common/tests/Printing/PrinterSettingsTests.cs +++ b/src/libraries/System.Drawing.Common/tests/Printing/PrinterSettingsTests.cs @@ -49,7 +49,6 @@ public void CanDuplex_ReturnsExpected() { var printerSettings = new PrinterSettings(); bool canDuplex = printerSettings.CanDuplex; - Assert.True(canDuplex); } [ConditionalFact(Helpers.IsDrawingSupported)] @@ -57,7 +56,6 @@ public void Copies_Default_ReturnsExpected() { var printerSettings = new PrinterSettings(); int copies = printerSettings.Copies; - Assert.Equal(1, copies); } [ConditionalTheory(Helpers.IsDrawingSupported)] @@ -87,7 +85,6 @@ public void Collate_Default_ReturnsExpected() { var printerSettings = new PrinterSettings(); bool collate = printerSettings.Collate; - Assert.True(collate); } [ConditionalFact(Helpers.IsDrawingSupported)] @@ -400,7 +397,6 @@ public void IsDirectPrintingSupported_ImageFormatSupported_ReturnsExpected(Image { var printerSettings = new PrinterSettings(); bool supported = printerSettings.IsDirectPrintingSupported(imageFormat); - Assert.True(supported); } public static IEnumerable IsDirectPrintingSupported_ImageFormatNotSupported_TestData()