Fix assignment analysis of ref fields #75340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Open
3 tasks
jjonescz
force-pushed
the
75315-RefFieldNeverAssigned
branch
from
9727861 to
500e713
Compare
RikkiGibson
reviewed
Oct 3, 2024
src/Compilers/CSharp/Portable/Symbols/Source/SourceAssemblySymbol.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Emit3/FlowAnalysis/RegionAnalysisTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Oct 7, 2024
RikkiGibson
approved these changes
Oct 8, 2024
|
@dotnet/roslyn-compiler for a second review, thanks |
jaredpar
reviewed
Oct 10, 2024
| @@ -846,15 +846,17 @@ private void NoteRead(BoundNode fieldOrEventAccess) | |||
| } | |||
| } | |||
|
|
|||
| protected virtual void NoteWrite(Symbol variable, BoundExpression value, bool read) | |||
| protected virtual void NoteWrite(Symbol variable, BoundExpression value, bool read, bool isRef) | |||
There was a problem hiding this comment.
Does isRef mean literally ref or any kind like in / out. Consider adding a comment here to make the intent clear.
There was a problem hiding this comment.
It means "ref assignment", so there's no in/out variant. Added a comment.
jaredpar
approved these changes
Oct 11, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75315.
A field cannot be assigned-to via a readonly reference, but previously we considered any reference to be a write and hence didn't emit the "field is never assigned" warning.
Similarly we didn't distinguish between ref assignments and value assignments of ref fields - now we consider only ref assignments to be writes to ref fields.
This also improves the warning to say that any never-assigned ref field will have its default value set to "null reference".