Merge "first-class Span types" feature into main #74732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add standard implicit array-to-Span conversions * Mitigate breaks in bootstrapped Roslyn * Add more tests * Improve code * Extend tests * Use implicit conversion instead of constructor * Improve code and tests * Update tests * Extend tests * Extend tests * Extend tests * Extend tests
* Add standard implicit array-to-Span conversions * Mitigate breaks in bootstrapped Roslyn * Add more tests * Improve code * Extend tests * Use implicit conversion instead of constructor * Improve code and tests * Update tests * Prefer implicit span conversions * Extend tests * Extend tests * Extend tests * Update new tests after merge * Revert "Mitigate breaks in bootstrapped Roslyn" This reverts commit a9556fa. * Mitigate remaining bootstrap break * Fix another instance of the same bootstrap break
Merge 'main' into features/FirstClassSpan
* Ignore user-defined Span conversions * Add a PROTOTYPE comment * Improve comments and tests
* Switch implicit span to conversion from type * Revert bootstrap build break mitigation * Improve code and tests * Simplify code
* Handle span conversions in expression trees * Improve test readability * Consolidate tests
* Use CreateCompilationWithSpanAndMemoryExtensions * Fix span source * Update tests on netcore * Avoid problems with string to ReadOnlySpan<T> * Use new span source * Revert "Avoid problems with string to ReadOnlySpan<T>" This reverts commit 2e98bd2. * Special-case a test
* Avoid span conversion in delegate extension receiver * Remove some bootstrap build break mitigation * Update comment
…#74587) * Disallow span conversions between spans which are not structs * Require ref struct
* Implement remaining span conversions * Simplify assert * Test more Span UDCs * Only ignore UDCs exactly matching compiler-defined conversions * Simplify code * Remove a redundant test * Extend tests * Require public MemoryExtensions
* Add span type inference * Simplify collection expression test helpers * Improve tests
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
VSCode
Needs API Review
3 tasks
* Test more breaking changes * Document the main breaking changes * Improve the doc
* Add `Enumerable.Reverse(this T[])` polyfill * Remove the extension method in .NET 10 Keeping it as non-extension for binary compatibility.
* Fix null coalescing operator emit with span conversion * Simplify check
jjonescz
force-pushed
the
FirstClassSpan-17-Main
branch
from
7827b1a to
d63c2fd
Compare
* Handle span conversions in `is` operator * Test `string` to ROS
jaredpar
approved these changes
Oct 10, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #73445