Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conversion.IsSpan public API #74731

Merged

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Aug 13, 2024

Test plan: #73445
Resolves #74738.

@dotnet-policy-service dotnet-policy-service bot added the Needs API Review Needs to be reviewed by the API review council label Aug 13, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 13, 2024
@jjonescz jjonescz marked this pull request as ready for review August 13, 2024 09:04
@jjonescz jjonescz requested review from a team as code owners August 13, 2024 09:04
@jjonescz jjonescz requested review from 333fred and cston August 13, 2024 09:04
@cston
Copy link
Member

cston commented Aug 13, 2024

Has the public API change been approved?

@jjonescz
Copy link
Member Author

Has the public API change been approved?

Not yet, I'm hoping this PR can serve as the ticket for the approval process.

@333fred
Copy link
Member

333fred commented Aug 13, 2024

Has the public API change been approved?

Not yet, I'm hoping this PR can serve as the ticket for the approval process.

Sorry, but please follow the process outlined in https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md.

@jjonescz jjonescz marked this pull request as draft August 13, 2024 17:28
@jjonescz jjonescz marked this pull request as ready for review August 30, 2024 07:02
@jjonescz
Copy link
Member Author

jjonescz commented Sep 2, 2024

@dotnet/roslyn-compiler for a second review, thanks (the API has been approved, see #74738)

@jjonescz jjonescz merged commit badc740 into dotnet:features/FirstClassSpan Sep 4, 2024
24 checks passed
@jjonescz jjonescz deleted the FirstClassSpan-16-Api branch September 4, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature - First-class Span Types Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants