Consider extension receiver conversion when reducing #73762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
commented
May 29, 2024
| var d1Access = tree.GetRoot().DescendantNodes().OfType<MemberAccessExpressionSyntax>() | ||
| .First(s => s.Expression.ToString() == "a"); | ||
| var lookupResult = model.LookupSymbols(d1Access.Name.SpanStart, aSymbol.Type, "M", includeReducedExtensionMethods: true); | ||
| AssertEx.Equal("System.Int32 System.Span<System.Int32>.M(System.Int32 y)", lookupResult.Single().ToTestDisplayString()); |
There was a problem hiding this comment.
Without the product change
- the error messages would be that the extension method is not applicable (CS1929) rather than that Span cannot be a delegate receiver (CS1113) - but that's just different diagnostics, so probably not very interesting
- however also this LookupSymbols would not be able to find the method
There was a problem hiding this comment.
FWIW, it looks like we'll report "error CS8917: The delegate type could not be inferred" rather than "error CS1113: Extension method ... cannot be used to create delegates" if the ReducedExtensionMethodSymbol change is removed.
jjonescz
changed the base branch from
dev/jjonescz/FirstClassSpan-02
to
features/FirstClassSpan
jjonescz
force-pushed
the
FirstClassSpan-04-ReducedExtensionMethod
branch
from
f8a481c to
2ff45e6
Compare
cston
approved these changes
Jun 13, 2024
333fred
approved these changes
Jun 13, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #73445