Walk green tree in SyntaxFacts.HasYieldOperations to avoid excessive allocations in reported trace #67221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler for reviews. |
CyrusNajmabadi
approved these changes
Mar 7, 2023
CyrusNajmabadi
approved these changes
Mar 7, 2023
|
@333fred Please consider giving this PR and the future merged commit a more descriptive title. What specific helpers are affected etc. |
333fred
changed the title
333fred
changed the title
|
@dotnet/roslyn-compiler @RikkiGibson for a second review. |
RikkiGibson
approved these changes
Mar 7, 2023
Co-authored-by: Rikki Gibson <[email protected]>
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is called for every method (from SourceOrdinaryMethodSymbol) and accounts for 10% of allocations in traces we are looking at. Continuation of #67198.