Force solution-asset system to fail if it can't find an asset for a checksum #67149
+20
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47013
This code was non-sensical. We could only get to the point where we would be trying to find an asset for a checksum once all the checksums/assets were already stored in the storage-scope. So if we had taht, but then can't find an asset for a checksum later, then that indicates a very very bad invariant problem. And definitely not something we want to paper over. It's unclear how this wouldn't just crash higher layers anyways as trying to get an asset, and returning null, would just break anything expecting a normally non-null asset (the common case for everything in the workspace).