-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI for editorconfig files #51069
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
faf7c13
Add UI for editorconfig files
jmarolf bab8e5d
update settings helper values for IOption2 writer
jmarolf 0cc4b9e
Update .gitignore
jmarolf c4ff7f3
Update src/EditorFeatures/Core/EditorConfigSettings/Extensions/Soluti…
jmarolf c1ec753
use WhereNotNull
jmarolf 837c00f
simplify null checking of array
jmarolf b619aef
fix tab backgound color in some themes
jmarolf a13246a
rename CreateGridElemetn to CreateItemElement
jmarolf ec7740f
use common guid
jmarolf ed97136
remove incorrect comment
jmarolf 759e0af
split types to separate files
jmarolf 0e84436
xaml it up
jmarolf 0d96fc1
set automation properties
jmarolf 56d6ec2
tweaks to filerability
jmarolf 22a61db
do not respond to workspace changed events instead let a new window b…
jmarolf 289aa3c
do not allow the user to sort or filter mutable data
jmarolf b7c06a3
add data tests
jmarolf f8f2106
xaml fixes found in testing
jmarolf 2976da0
remove async from data providers
jmarolf 7e21933
simplify view
jmarolf e3df1f6
fix text header
jmarolf c8472e1
ensure that AnalyzerConfigOptionsResult is consulted
jmarolf 0f65913
handle null case in tests
jmarolf d1af11b
simplify threading for updating code
jmarolf b21007b
simplfy updating threading model for editorconfig buffer
jmarolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
...torConfigSettings/DataProvider/CodeStyle/CSharpCodeStyleSettingsLanguageServiceFactory.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using System.Composition; | ||
using Microsoft.CodeAnalysis; | ||
using Microsoft.CodeAnalysis.Editor.EditorConfigSettings.Data; | ||
using Microsoft.CodeAnalysis.Editor.EditorConfigSettings.DataProvider; | ||
using Microsoft.CodeAnalysis.Host; | ||
using Microsoft.CodeAnalysis.Host.Mef; | ||
|
||
namespace Microsoft.VisualStudio.LanguageServices.CSharp.EditorConfigSettings.DataProvider.CodeStyle | ||
{ | ||
[ExportLanguageServiceFactory(typeof(ILanguageSettingsProviderFactory<CodeStyleSetting>), LanguageNames.CSharp), Shared] | ||
internal class CSharpCodeStyleSettingsLanguageServiceFactory : ILanguageServiceFactory | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so this is like a factory factory? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't wnat to write that but... |
||
{ | ||
[ImportingConstructor] | ||
[Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
public CSharpCodeStyleSettingsLanguageServiceFactory() | ||
{ | ||
} | ||
|
||
public ILanguageService CreateLanguageService(HostLanguageServices languageServices) | ||
{ | ||
var workspace = languageServices.WorkspaceServices.Workspace; | ||
return new CSharpCodeStyleSettingsProviderFactory(workspace); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are copied from a higher layer. There is no reason these types need to be in the VS layer instead of the Editor layer other than the resources but I can move the types back if we don't want to worry about it.
CSharpCodeStyleOptions.UnusedValueExpressionStatement
is a C# only option as far as I can tell. if we ever offer the ability to enforce this for VB then we should move it.