Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It looks like GetDisposalInfoForEnumerator never reports diagnostics produced by TryFindDisposePatternMethod #73934

Closed
AlekseyTs opened this issue Jun 11, 2024 · 0 comments · Fixed by #75422
Closed

It looks like GetDisposalInfoForEnumerator never reports diagnostics produced by TryFindDisposePatternMethod #73934

AlekseyTs opened this issue Jun 11, 2024 · 0 comments · Fixed by #75422
Assignees
@jcouv
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality untriaged Issues and PRs which have not yet been triaged by a lead
Milestone
Backlog

Comments

@AlekseyTs
Copy link
Contributor

This is inconsistent with other call sites for the helper, and quite possibly fails to report something useful, or record important dependencies.
@AlekseyTs AlekseyTs added Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Jun 11, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 11, 2024
@jaredpar jaredpar added this to the Backlog milestone Jun 11, 2024
@jcouv jcouv self-assigned this Oct 7, 2024
@jcouv jcouv mentioned this issue Oct 7, 2024
Merged
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Report diagnostics from TryFindDisposePatternMethod when binding foreach loop jcouv/roslyn
3 participants
@jaredpar @AlekseyTs @jcouv