Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for MSBuildWorkspace on Windows containing options with quotes in them #71021

Closed
jasonmalinowski opened this issue Nov 29, 2023 · 1 comment
Closed

Add tests for MSBuildWorkspace on Windows containing options with quotes in them #71021

jasonmalinowski opened this issue Nov 29, 2023 · 1 comment
Assignees
@jasonmalinowski
Labels
Area-IDE IDE-MSBuildWorkspace MSBuildWorkspace
Milestone
Backlog

Comments

@jasonmalinowski
Copy link
Member

As observed in #70469 (comment) we might have problems if you are passing MSBuild properties that require escaping.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 29, 2023
@jasonmalinowski jasonmalinowski self-assigned this Nov 29, 2023
@jasonmalinowski jasonmalinowski changed the title Add tests for MSBuildWorkspace on Linux containing options with quotes in them Add tests for MSBuildWorkspace on Windows containing options with quotes in them Nov 29, 2023
@jasonmalinowski jasonmalinowski added this to the 17.9 milestone Dec 1, 2023
@jasonmalinowski jasonmalinowski removed the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 1, 2023
@CyrusNajmabadi CyrusNajmabadi added the IDE-MSBuildWorkspace MSBuildWorkspace label Oct 25, 2024
@arunchndr arunchndr modified the milestones: 17.9, Backlog Oct 28, 2024
@CyrusNajmabadi
Copy link
Member

Closing out as speculative. If we need tests, then just add tests. Backlog issues don't help us here.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE IDE-MSBuildWorkspace MSBuildWorkspace
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jasonmalinowski @CyrusNajmabadi @arunchndr