Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection expressions: handle use site diagnostics and other complex cases when using well-known members #70241

Open
RikkiGibson opened this issue Oct 4, 2023 · 3 comments
Assignees
Milestone

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Oct 4, 2023

Regarding issues with use-site diagnostics, Obsolete, constraint checks, etc. I think we should punt them to 17.9. I'm happy to take on that work. I think it is OK for the the tooling to behave badly in the short term if someone implements this framework-level API in an unexpected fashion. e.g. producing an assembly that fails at runtime, or missing expected diagnostics at compile time.

Originally posted by @RikkiGibson in #70222 (comment)

Relates to test plan: #66418

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 4, 2023
@RikkiGibson RikkiGibson self-assigned this Oct 4, 2023
@RikkiGibson RikkiGibson added this to the 17.9 milestone Oct 4, 2023
@jcouv jcouv added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 11, 2023
@RikkiGibson RikkiGibson modified the milestones: 17.9, 17.10 Jan 11, 2024
@jaredpar jaredpar modified the milestones: 17.10, Backlog Mar 26, 2024
@jcouv
Copy link
Member

jcouv commented Oct 15, 2024

Part of this issue relates to Obsolete and constraints checks on well-known types/members. We discussed this topic earlier today with Jared/Aleksey/Fred and I wanted to record the team's stance: we're okay not to check Obsolete, UnmanagedCallersOnly or unexpected constraints on well-known types/members. I'm in process of documenting that.

@RikkiGibson
Copy link
Contributor Author

What remains in this issue that we would actually want to implement? Checking use site diagnostics?

@AlekseyTs
Copy link
Contributor

And collecting dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants