Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: Add a code action that updates all call-sites of a method with changed signature #69197

Open
tmat opened this issue Jul 24, 2023 · 1 comment

Comments

@tmat
Copy link
Member

tmat commented Jul 24, 2023

When a method signature is changed during EnC/Hot Reload, we update the existing method to throw MethodMissingException and add method with the new signature. The callers are not updated unless the user explicitly makes changes to them.

In some cases we will be able to emit a trampoline to the old method that calls the new method, but not in all cases.

The EnC analyzer could squiggle the updated method signature and provide a code action that finds all call-sites of the previous version of the method and updates their containing methods. If executed before the signature change is applied it would be part of the change. Otherwise, it would trigger a new update.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 24, 2023
@tmat tmat added Interactive-EnC and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 24, 2023
@tmat
Copy link
Member Author

tmat commented Jul 24, 2023

@davidwengier FYI

@arunchndr arunchndr added this to the Backlog milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants