Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Enable support for F# semantic classifications #64168

Open
allisonchou opened this issue Sep 21, 2022 · 6 comments
Open

[LSP] Enable support for F# semantic classifications #64168

allisonchou opened this issue Sep 21, 2022 · 6 comments
Assignees
Labels
Area-IDE Bug LSP issues related to the roslyn language server protocol implementation
Milestone

Comments

@allisonchou
Copy link
Contributor

F# semantic tokens will currently not work with the LSP semantic tokens feature flag enabled. The primary hurdle is designing a way to retrieve F# classification types and include them in the Roslyn LSP semantic tokens legend.

@allisonchou allisonchou added the LSP issues related to the roslyn language server protocol implementation label Sep 21, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 21, 2022
@CyrusNajmabadi
Copy link
Member

We shoudl be able to find a way to retrieve those classification types with MEF (though, importantly, in a way that doesn't actually instantiate instances of F# types, causing those dlls to load). MEF def supports this.

@dibarbet thinks it may already be possible to see what type-definitions F# is already exporting and examine thsoe. If that works, great! If not, we should be able to define a new attribute/interface for this and query it for just thsi purpose.

@vzarytovskii
Copy link
Member

Hey folks, we already do some classification internally, how we would expose that so Roslyn can utilize that?

@CyrusNajmabadi
Copy link
Member

@vzarytovskii
Copy link
Member

Don't you already support this through: main/src/Tools/ExternalAccess/FSharp/Classification/IFSharpClassificationService.cs ?

We do our own semantic classification, but apparently, it does not play well with LSP semantic tokens?

@dibarbet
Copy link
Member

@psfinaki
Copy link
Member

Hi @dibarbet - we're getting back on this topic in the light of the increasing LSP presence in VS. Can you share any update on that, or maybe you would like some extra info from the F# side?

@arunchndr arunchndr added this to the 18.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Development

No branches or pull requests

6 participants