Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify SettingsUpdateHelper and ConfigurationUpdater implementation #52735

Closed
jmarolf opened this issue Apr 19, 2021 · 4 comments
Closed

Unify SettingsUpdateHelper and ConfigurationUpdater implementation #52735

jmarolf opened this issue Apr 19, 2021 · 4 comments
Assignees
@jmarolf
Labels
Area-IDE Concept-Continuous Improvement
Milestone
17.6 P2

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Apr 19, 2021

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 19, 2021
@jmarolf jmarolf self-assigned this Apr 19, 2021
@jmarolf jmarolf mentioned this issue Apr 19, 2021
Merged
4 tasks
@mavasani
Copy link
Contributor

mavasani commented Apr 19, 2021 •
edited
Loading

RE: Are there tests for ConfigurationUpdater?

There are no direct unit tests for this compoment, but it is thoroughly tested from the unit tests for Configure Severity and Configure Option lightbulb actions: https://github.com/dotnet/roslyn/tree/main/src/EditorFeatures/CSharpTest/Diagnostics/Configuration

@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2021
@jinujoseph jinujoseph added this to the 16.11 milestone Apr 20, 2021
@jmarolf jmarolf mentioned this issue Apr 26, 2021
Closed
@jinujoseph jinujoseph modified the milestones: 16.11, 17.0 Jul 16, 2021
@jmarolf jmarolf modified the milestones: 17.0, 17.1 Oct 6, 2021
@jmarolf jmarolf mentioned this issue Dec 2, 2021
Merged
@jmarolf
Copy link
Contributor Author

jmarolf commented Dec 2, 2021

Should ensure that we normalize the way line endings are added as part of this. I like @Youssef1313's suggested behavior here: #58075 (comment)

@jmarolf jmarolf modified the milestones: 17.1, 17.2 Jan 11, 2022
@jmarolf
Copy link
Contributor Author

jmarolf commented Mar 18, 2022

related to #54556

@jmarolf jmarolf mentioned this issue Mar 18, 2022
Open
@jinujoseph jinujoseph modified the milestones: 17.2, 17.3 May 5, 2022
@arunchndr arunchndr modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
@CyrusNajmabadi
Copy link
Member

Closing out as speculative.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarolf jmarolf

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
17.6 P2
Development

No branches or pull requests
5 participants
@CyrusNajmabadi @jmarolf @mavasani @jinujoseph @arunchndr