Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace Symbol search in OOP LSP only supports streaming #48151

Closed
davidwengier opened this issue Sep 29, 2020 · 1 comment · Fixed by #48753
Closed

Workspace Symbol search in OOP LSP only supports streaming #48151

davidwengier opened this issue Sep 29, 2020 · 1 comment · Fixed by #48753
Assignees
@davidwengier
Labels
Area-IDE Concept-Continuous Improvement LSP issues related to the roslyn language server protocol implementation
Milestone
16.9

Comments

@davidwengier
Copy link
Contributor

This one: https://github.com/dotnet/roslyn/blob/master/src/Workspaces/Remote/ServiceHub/Services/LanguageServer/LanguageServer.cs#L102

We should support streaming, and just return return results when the client prefers that.
@davidwengier davidwengier self-assigned this Sep 29, 2020
@davidwengier davidwengier mentioned this issue Sep 29, 2020
Merged
@dibarbet dibarbet mentioned this issue Oct 6, 2020
Closed
@jinujoseph jinujoseph added LSP issues related to the roslyn language server protocol implementation Concept-Continuous Improvement labels Oct 6, 2020
@jinujoseph jinujoseph added this to the 16.9 milestone Oct 6, 2020
@davidwengier davidwengier mentioned this issue Oct 19, 2020
Merged
@davidwengier
Copy link
Contributor Author

Fixed in #48753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Area-IDE Concept-Continuous Improvement LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
16.9
Development

Successfully merging a pull request may close this issue.

Update LSP handlers to make streaming results optional, or possible davidwengier/roslyn
2 participants
@davidwengier @jinujoseph