New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolutionAssetStorage.GetAssetAsync should never return null #47013

Closed

tmat opened this issue Aug 20, 2020 · 0 comments · Fixed by #67149

Labels

Area-IDE Concept-Continuous Improvement Concept-OOP

Milestone

Member

tmat commented Aug 20, 2020 •

edited

Loading

We should throw if we can't find the asset instead of returning null. Not being able to find an asset indicates a bug in the implementation.

Similarly for FindAsset and other methods in the class.

tmat added Concept-Continuous Improvement Concept-OOP labels

tmat mentioned this issue

Simplify RemotableDataService #46893

Merged

jinujoseph added the Area-IDE label

jinujoseph added this to the Backlog milestone

CyrusNajmabadi mentioned this issue

Force solution-asset system to fail if it can't find an asset for a checksum #67149

Merged

CyrusNajmabadi closed this as completed in #67149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment