Methods marked with the JetBrains UsedImplicitly attribute have an IDE0051 warning

[vsfeedback]

This issue has been moved from a ticket on Developer Community.

---

[regression] [worked-in:15.9.16]
Methods marked with the JetBrains attribute [UsedImplicitly] are greyed out with an IDE0051 analysis warning
For instance using PropertyChanged.Fody for classes that implement INotifyPropertyChanged there is no need to call the private method OnPropertyChanged in the C# file.
In Visual Studio 2017 the UsedImplicitly attribute was correctly recognised and there was no IDE0051 warning

using System.ComponentModel;
using System.Runtime.CompilerServices;
using JetBrains.Annotations;

namespace ExampleAnalysisIssue
{
    [UsedImplicitly]
    public sealed class Class1 : INotifyPropertyChanged
    {
        public int Data { get; set; }

public event PropertyChangedEventHandler PropertyChanged;

[NotifyPropertyChangedInvocator]
        [UsedImplicitly]
        private void OnPropertyChanged([CallerMemberName] string propertyName = null)
        {
            PropertyChanged?. Invoke(this, new PropertyChangedEventArgs(propertyName));
        }
    }
}

---

Original Comments

Visual Studio Feedback System on 10/3/2019, 00:11 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

---

Original Solutions

(no solutions)

[sharwell]

📝 I believe IDE0051 is new for Visual Studio 2019

[mavasani]

I believe this is by design and duplicate of #35767 (comment). The recommended approach would be to author a DiagnosticSuppressor for programmatically suppressing all violations on types with any extension specific attributes OR apply source suppressions for each case. I presume former is more preferable.

[mavasani]

Such a diagnostic suppressor should then ship along with the package that adds such attributes. So for this case, JetBrains should author a DiagnosticSuppressor for IDE0051 and suppress it whenever it sees symbols with its custom attribute, and ship this suppressor along with their package.

[godrose]

This is a breaking change. Has anyone in MS even contacted JEtBrains on that matter?

[CyrusNajmabadi]

This is a breaking change

This is not a breaking change.

Has anyone in MS even contacted JEtBrains on that matter?

I'm unaware of any contact to jetbrains here. The information was provided so that the original filer could forward things along if they wished to do that.