Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider if SuppressionDescriptor should be a struct #36568

Closed
mavasani opened this issue Jun 19, 2019 · 1 comment
Closed

Consider if SuppressionDescriptor should be a struct #36568

mavasani opened this issue Jun 19, 2019 · 1 comment
Labels
Area-Analyzers Concept-Continuous Improvement
Milestone
Backlog

Comments

@mavasani
Copy link
Contributor

#36067 adds a new public API SuppressionDescriptor which is analogous to DiagnosticDescriptor - DiagnosticSuppressor declaratively provides its supported suppression descriptors, similar to the way that DiagnosticAnalyzer provides its supported diagnostic descriptors. SuppressionDescriptor is a class in the PR for consistency with DiagnosticDescriptor. It was suggested here that it could be a struct. This issue tracks whether or not to make this change.
@mavasani mavasani mentioned this issue Jun 19, 2019
Merged
@jinujoseph jinujoseph added this to the Backlog milestone Jun 19, 2019
@CyrusNajmabadi
Copy link
Member

Closing out.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Analyzers Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@CyrusNajmabadi @mavasani @jinujoseph