Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False "remove unused fields" & methods from XAML events #35429

Closed
clairernovotny opened this issue May 2, 2019 · 3 comments
Closed

False "remove unused fields" & methods from XAML events #35429

clairernovotny opened this issue May 2, 2019 · 3 comments
Assignees
@mavasani
Labels
Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings Resolution-Duplicate The described behavior is tracked in another issue
Milestone
16.3

Comments

@clairernovotny
Copy link
Member

clairernovotny commented May 2, 2019 •
edited
Loading

Version Used: latest

Steps to Reproduce:

  1. Clone https://github.com/NuGetPackageExplorer/NuGetPackageExplorer
  2. Look at the information roslyn detects

Expected Behavior:
It should not have suggestions for removing unused parameters from event handlers where the signature matters. It also misses one event entirely and sees it as unused.

Actual Behavior:
image
@jcouv jcouv added the Area-IDE label May 6, 2019
@vatsalyaagrawal vatsalyaagrawal added Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels May 6, 2019
@vatsalyaagrawal vatsalyaagrawal added this to the 16.2 milestone May 6, 2019
@mavasani mavasani modified the milestones: 16.2, 16.3 Jun 24, 2019
@mavasani
Copy link
Contributor

Duplicate of #37483 (comment)

@mavasani mavasani marked this as a duplicate of #37483 Aug 19, 2019
@mavasani mavasani added the Resolution-Duplicate The described behavior is tracked in another issue label Aug 19, 2019
@mavasani
Copy link
Contributor

Re-opening and tagging for design review so it can be discussed at next IDE design meeting.

@mavasani mavasani reopened this Aug 21, 2019
@mavasani
Copy link
Contributor

Oops, meant to re-open the original against which this was duped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings Resolution-Duplicate The described behavior is tracked in another issue
Projects
None yet
Milestone
16.3
Development

No branches or pull requests
4 participants
@clairernovotny @vatsalyaagrawal @mavasani @jcouv