Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No verifier spec is available for new codegen used for non-mutating structs #22671

Closed
marek-safar opened this issue Oct 12, 2017 · 2 comments
Closed

Comments

@marek-safar
Copy link
Contributor

Version Used: 2.6.0.62126 (1758d50)

To support the new Roslyn behaviour updated verifier spec should be available also for readonly struct codegen (the similar case was by-ref returns). With that, we could update Mono verifier implementation not to reject newly generated code.

The request is extracted from #22485

@jcouv
Copy link
Member

jcouv commented Nov 5, 2017

Relates to #22872

@jcouv jcouv added this to the 16.0 milestone Nov 5, 2017
@VSadov
Copy link
Member

VSadov commented Nov 7, 2017

Proposal of extension to IL verification rules that would account for new features were posed here:

dotnet/designs#17 - ref returns
dotnet/designs#21 - readonly references

I think the further discussions should happen over there.

(note there likely will be some minor work on the Roslyn side to be fully compliant with the rules, once we agree on the rules)

@VSadov VSadov closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants