Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order in which type forwarders are emitted to ExportedType table is non-deterministic #11990

Closed
tmat opened this issue Jun 14, 2016 · 1 comment · Fixed by #16303
Closed
Assignees
Labels
2 - Ready Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time.
Milestone

Comments

@tmat
Copy link
Member

tmat commented Jun 14, 2016

PEModuleBuilder.GetForwardedTypes enumerates a hash set (http://source.roslyn.io/#Microsoft.CodeAnalysis.CSharp/Emitter/Model/PEModuleBuilder.cs,cef579e20a0e694c,references)

  foreach (NamedTypeSymbol forwardedType in wellKnownAttributeData.ForwardedTypes)
  {
     NamedTypeSymbol originalDefinition = forwardedType.OriginalDefinition;
     ...
     stack.Push(originalDefinition);
     ...
                    while (stack.Count > 0)
                    {
                        NamedTypeSymbol current = stack.Pop();
 ...
                        builder.Add(current);
... 
                    }

  }
@tmat tmat added Area-Compilers Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. labels Jun 14, 2016
@tmat
Copy link
Member Author

tmat commented Jun 14, 2016

@gafter FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Ready Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants