Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Allow var for fields and assigned auto properties #11551

Closed
drewnoakes opened this issue May 25, 2016 · 1 comment
Closed

Proposal: Allow var for fields and assigned auto properties #11551

drewnoakes opened this issue May 25, 2016 · 1 comment

Comments

@drewnoakes
Copy link
Member

Repeating the type name multiple times in a line feels outdated since we've had var for locals.


var for assigned fields

private readonly Dictionary<UserProfile, HashSet<string>> _stringsByProfile
    = new Dictionary<UserProfile, HashSet<string>>();

Becomes

private readonly var _nameById = new Dictionary<UserProfile, HashSet<string>>();

var for assigned auto properties

public Dictionary<UserProfile, HashSet<string>> NameById { get; }
    = new Dictionary<UserProfile, HashSet<string>>();

Becomes

public var NameById { get; } = new Dictionary<UserProfile, HashSet<string>>();

There have been some fairly adventurous suggestions for extending type inference for C#, many of which seem interesting but potentially complex or tricky (eg, for method return values, method args, not-immediately-assigned declarations). IMO the above two examples are just a natural extension of the way var works today. A new C# developer might reasonably be surprised to learn that var isn't allowed in the above examples.

@dsaf
Copy link

dsaf commented May 25, 2016

@gafter
Copy link
Member

gafter commented Mar 24, 2017

We are now taking language feature discussion in other repositories:

Features that are under active design or development, or which are "championed" by someone on the language design team, have already been moved either as issues or as checked-in design documents. For example, the proposal in this repo "Proposal: Partial interface implementation a.k.a. Traits" (issue 16139 and a few other issues that request the same thing) are now tracked by the language team at issue 52 in https://github.com/dotnet/csharplang/issues, and there is a draft spec at https://github.com/dotnet/csharplang/blob/master/proposals/default-interface-methods.md and further discussion at issue 288 in https://github.com/dotnet/csharplang/issues. Prototyping of the compiler portion of language features is still tracked here; see, for example, https://github.com/dotnet/roslyn/tree/features/DefaultInterfaceImplementation and issue 17952.

In order to facilitate that transition, we have started closing language design discussions from the roslyn repo with a note briefly explaining why. When we are aware of an existing discussion for the feature already in the new repo, we are adding a link to that. But we're not adding new issues to the new repos for existing discussions in this repo that the language design team does not currently envision taking on. Our intent is to eventually close the language design issues in the Roslyn repo and encourage discussion in one of the new repos instead.

Our intent is not to shut down discussion on language design - you can still continue discussion on the closed issues if you want - but rather we would like to encourage people to move discussion to where we are more likely to be paying attention (the new repo), or to abandon discussions that are no longer of interest to you.

If you happen to notice that one of the closed issues has a relevant issue in the new repo, and we have not added a link to the new issue, we would appreciate you providing a link from the old to the new discussion. That way people who are still interested in the discussion can start paying attention to the new issue.

Also, we'd welcome any ideas you might have on how we could better manage the transition. Comments and discussion about closing and/or moving issues should be directed to #18002. Comments and discussion about this issue can take place here or on an issue in the relevant repo.


I am not moving this particular issue because I don't have confidence that the LDM would likely consider doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants