Port CA2208: InstantiateArgumentExceptionsCorrectly #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| compilationContext => | ||
| { | ||
| Compilation compilation = compilationContext.Compilation; | ||
| ITypeSymbol stringType = compilation.GetSpecialType(SpecialType.System_String); |
There was a problem hiding this comment.
You don't need to fetch/store the special types. Instead you can directly ask for the special type on the type symbols. Basically replace your argument.Parameter.Type != stringType checks with argument.Parameter.Type.SpecialType != SpecialType.System_String
nguerrera
force-pushed
the
argument-exception-port
branch
from
d18758b to
ff57cee
Compare
nguerrera
force-pushed
the
argument-exception-port
branch
from
ff57cee to
7f2836b
Compare
|
|
||
|
|
||
| private const string s_helpUri = "https://msdn.microsoft.com/en-us/library/ms182347.aspx"; | ||
|
|
||
| internal static DiagnosticDescriptor NoArgumentsRule = new DiagnosticDescriptor(RuleId, |
There was a problem hiding this comment.
/cc @srivatsn This seems to be another rule where FXCop generates different diagnostic messages for same Rule ID. @nguerrera We have decided to avoid having multiple descriptors with the same Rule ID which differ only in the containing message. You should create a single descriptor with a placeholder message format "{0}" and provide specific message as a messageArgument to Diagnostic.Create method.
nguerrera
changed the title
|
LGTM |
|
👍 |
nguerrera
added a commit
that referenced
this pull request
Dec 8, 2015
Port CA2208: InstantiateArgumentExceptionsCorrectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#531 (fixer to follow in another PR)