Add string.Format / StringBuilder.AppendFormat CompositeFormat analyzer #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
compositeformatanalyzer
branch
3 times, most recently
from
66c5085 to
0b7952e
Compare
buyaa-n
reviewed
Jun 27, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseCompositeFormat.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Jun 27, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseCompositeFormat.cs
Show resolved
Hide resolved
buyaa-n
reviewed
Jun 27, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseCompositeFormat.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Jun 27, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseCompositeFormat.cs
Show resolved
Hide resolved
|
JFYI: got a conflicts |
stephentoub
force-pushed
the
compositeformatanalyzer
branch
from
a495373 to
116022b
Compare
|
@buyaa-n, feedback and conflicts addressed. |
buyaa-n
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Build still failing because of generated files, seems need to run msbuild /t:pack once more:
Missing entry in D:\a\_work\1\s\src\NetAnalyzers\RulesMissingDocumentation.md
CA1863 | <[https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1863>](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1863%3E) | Use 'CompositeFormat' |
One or more auto-generated documentation files were either edited manually, or not updated. Please revert changes made to the following files (if manually edited) and run `msbuild /t:pack` at the root of the repo to automatically update them:
Otherwise LGTM, thank you!
stephentoub
force-pushed
the
compositeformatanalyzer
branch
from
fe0d27a to
86308ae
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6675 +/- ##
==========================================
- Coverage 96.36% 96.36% -0.01%
==========================================
Files 1392 1394 +2
Lines 324270 324631 +361
Branches 10621 10644 +23
==========================================
+ Hits 312497 312836 +339
- Misses 9225 9239 +14
- Partials 2548 2556 +8 |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/runtime#85525
This PR provides an analyzer. It still warrants a fixer.