Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown files to comply to markdown guidelines #4141

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Sep 8, 2020

No description provided.

@Evangelink Evangelink requested a review from a team as a code owner September 8, 2020 09:46
@Evangelink
Copy link
Member Author

This is a one-off change. Regarding the various documentation files this is a manual modification but we don't have any automatic linter that would prevent new errors to be introduced.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #4141 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4141   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files        1163     1163           
  Lines      262725   262725           
  Branches    15829    15829           
=======================================
+ Hits       251655   251658    +3     
+ Misses       9064     9063    -1     
+ Partials     2006     2004    -2     

@mavasani
Copy link
Contributor

mavasani commented Sep 8, 2020

@Evangelink The change looks good to me, but does not fix #4131. I have removed the Fix #4131 comment. Fixing that issue needs fixing the code fix so AnalyzerReleases.*.md files have valid content:

private static Task<SourceText> AddOrUpdateEntriesToUnshippedFileAsync(
TextDocument unshippedDataDocument,
SortedSet<string>? entriesToAdd,
Dictionary<string, string>? entriesToUpdate,
CancellationToken cancellationToken)
{
// Split entries to add into New rule entries and Changed rule entries as they should be added to separate tables.
// New rule entry:
// "Rule ID | Category | Severity | HelpLink (optional)"
// " 0 | 1 | 2 | 3 "
//
// Changed rule entry:
// "Rule ID | New Category | New Severity | Old Category | Old Severity | HelpLink (optional)"
// " 0 | 1 | 2 | 3 | 4 | 5 "

Also note that AnalyzerReleases.*.md are additional files for release tracking analyzer, so I would only recommend changing whitespace/newline content in the code fix, unless you also want to update the analyzer, which might break the analyzer from reading existing AnalyzerReleases.*.md files.

@mavasani mavasani merged commit 2272c7b into dotnet:master Sep 8, 2020
@Evangelink Evangelink deleted the markdown branch September 9, 2020 08:21
@Youssef1313
Copy link
Member

This is a one-off change. Regarding the various documentation files this is a manual modification but we don't have any automatic linter that would prevent new errors to be introduced.

@mavasani @Evangelink Do you want a linter workflow for PRs?
dotnet/docs is using one, it should be copy/paste to set the workflow for this repo.

https://github.com/dotnet/docs/blob/master/.github/workflows/markdownlint.yml
https://github.com/dotnet/docs/blob/master/.github/workflows/markdownlint-problem-matcher.json

We can temporarily exclude AnalyzerReleases.*.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants