-
Notifications
You must be signed in to change notification settings - Fork 468
/
UseNameofInPlaceOfString.cs
133 lines (114 loc) · 5.3 KB
/
UseNameofInPlaceOfString.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the MIT license. See License.txt in the project root for license information.
using System.Collections.Immutable;
using System.Linq;
using Analyzer.Utilities;
using Analyzer.Utilities.Extensions;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Operations;
namespace Microsoft.CodeQuality.Analyzers.Maintainability
{
using static MicrosoftCodeQualityAnalyzersResources;
/// <summary>
/// CA1507: <inheritdoc cref="UseNameOfInPlaceOfStringTitle"/>
/// </summary>
public abstract class UseNameofInPlaceOfStringAnalyzer : DiagnosticAnalyzer
{
internal const string RuleId = "CA1507";
private const string ParamName = "paramName";
private const string PropertyName = "propertyName";
internal const string StringText = "StringText";
internal static readonly DiagnosticDescriptor RuleWithSuggestion = DiagnosticDescriptorHelper.Create(
RuleId,
CreateLocalizableResourceString(nameof(UseNameOfInPlaceOfStringTitle)),
CreateLocalizableResourceString(nameof(UseNameOfInPlaceOfStringMessage)),
DiagnosticCategory.Maintainability,
RuleLevel.IdeSuggestion,
description: CreateLocalizableResourceString(nameof(UseNameOfInPlaceOfStringDescription)),
isPortedFxCopRule: false,
isDataflowRule: false);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create(RuleWithSuggestion);
protected abstract bool IsApplicableToLanguageVersion(ParseOptions options);
public override void Initialize(AnalysisContext context)
{
context.EnableConcurrentExecution();
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
context.RegisterOperationAction(AnalyzeArgument, OperationKind.Argument);
}
private void AnalyzeArgument(OperationAnalysisContext context)
{
if (!IsApplicableToLanguageVersion(context.Operation.Syntax.SyntaxTree.Options))
{
return;
}
var argument = (IArgumentOperation)context.Operation;
if (argument.Parameter == null
|| argument.Value.Kind != OperationKind.Literal
|| argument.ArgumentKind != ArgumentKind.Explicit
|| argument.Value.Type?.SpecialType != SpecialType.System_String
|| !argument.Value.ConstantValue.HasValue
|| argument.Value.ConstantValue.Value is not string stringText)
{
return;
}
// argument.Parameter will not be null here. The only case for it to be null is an __arglist argument, for which
// the argument type will not be of SpecialType.System_String.
switch (argument.Parameter.Name)
{
case ParamName:
if (HasAnyParameterMatchInScope(context, stringText))
{
context.ReportDiagnostic(argument.Value.CreateDiagnostic(RuleWithSuggestion, stringText));
}
return;
case PropertyName:
if (HasAnyPropertyMatchInScope(context, stringText))
{
context.ReportDiagnostic(argument.Value.CreateDiagnostic(RuleWithSuggestion, stringText));
}
return;
default:
return;
}
}
private static bool HasAnyPropertyMatchInScope(OperationAnalysisContext context, string stringText)
{
var containingType = context.ContainingSymbol.ContainingType;
return containingType?.GetMembers(stringText).Any(m => m.Kind == SymbolKind.Property) == true;
}
private static bool HasAnyParameterMatchInScope(OperationAnalysisContext context, string stringText)
{
// get the parameters for the containing method
foreach (var parameter in context.ContainingSymbol.GetParameters())
{
if (parameter.Name == stringText)
{
return true;
}
}
// and loop through the ancestors to find parameters of anonymous functions and local functions
var parentOperation = context.Operation.Parent;
while (parentOperation != null)
{
IMethodSymbol? methodSymbol = parentOperation switch
{
IAnonymousFunctionOperation anonymousOperation => anonymousOperation.Symbol,
ILocalFunctionOperation localFunctionOperation => localFunctionOperation.Symbol,
_ => null
};
if (methodSymbol is not null)
{
foreach (var methodParameter in methodSymbol.Parameters)
{
if (methodParameter.Name == stringText)
{
return true;
}
}
}
parentOperation = parentOperation.Parent;
}
return false;
}
}
}