Cleanup duplicating targets

[YuliiaKovalova]

Summary

Common to both project systems design time build targets were added to https://devdiv.visualstudio.com/DevDiv/_git/ProjectServices/commit/fecd52a99dfab9ac1a6896ce4b4271cb5015da7e?refName=refs/heads/main&path=/src/Microsoft.VisualStudio.ProjectServices/Microsoft.DesignTime.targets

Feel free to cleanup the duplicating targets:
CollectCopyToOutputDirectoryItemDesignTime
CompileDesignTime
_CheckCompileDesignTimePrerequisite

User Impact

No visible impact. The listed targets are delivered in VS as a part of ProjectServices insertion and imported by msbuild
https://github.com/dotnet/msbuild/pull/10732/files

[drewnoakes]

@YuliiaKovalova if I understand dotnet/msbuild#10732 and dotnet/msbuild#10698, then we would expect the ProjectServices's Microsoft.DesignTime.targets to be available in VS and imported by MSBuild already, so it would just be a case of diffing the implementations and removing ours if possible. Does that sound right?

[YuliiaKovalova]

Yes, it's correct. MSBuild will resolve the case for the targets duplicates.
Since ProjectService is shipped with VS even with the bare workload installation, we decided to keep you posted on this possible cleanup.