Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retargeting support #5691

Closed
davidwengier opened this issue Dec 2, 2019 · 5 comments
Closed

Add retargeting support #5691

davidwengier opened this issue Dec 2, 2019 · 5 comments
Assignees
@davidwengier
Labels
Feature-WinUI Feature-Xamarin Resolution-Duplicate The bug is a duplicate of another bug in this or another repo. Triage-Approved Reviewed and prioritized
Milestone
16.7

Comments

@davidwengier
Copy link
Contributor

CPS currently implements IVsRetargetProjectAsync so we need to validate or possible expand that support, and then implement WinUI retargeting on top of it.

  • Property Pages
  • Template wizard
  • IVsRetargetProject retargeting (retargeting entire solution to new version, prompting when prerequisite is missing)

Retargeting .NET Core projects should be considered too, and could be a way to work on this without being blocked on WinUI support.
@davkean
Copy link
Member

davkean commented Dec 2, 2019

Have a look at how we did this for UWP/Portable/Phone here: http://index/?leftProject=Microsoft.VisualStudio.ProjectFlavoring&file=Microsoft%5CVisualStudio%5CProjectFlavoring%5CRetargeting%5CVsRetargetProjectManager.cs. I would port this as it adds a simplified layer (separating into "Acquisition" and "Retargeting") over IVsRetargetProject

@davidwengier davidwengier added this to the 16.6 milestone Dec 2, 2019
@davkean
Copy link
Member

davkean commented Dec 2, 2019

Although bear in mind that looks like it changed to hardcode Windows SDK platforms for some reason, which should be removed.

@davidwengier davidwengier self-assigned this Dec 5, 2019
@drewnoakes drewnoakes added the Triage-Approved Reviewed and prioritized label Dec 10, 2019
@davkean davkean mentioned this issue Jan 20, 2020
Open
@davkean
Copy link
Member

davkean commented Feb 6, 2020

We should factor in missing SDKs, and the aquisition of SDKs.

@davidwengier davidwengier modified the milestones: 16.6, Backlog Mar 20, 2020
@davkean davkean modified the milestones: Backlog, 16.7 Mar 20, 2020
@davkean
Copy link
Member

davkean commented Mar 20, 2020

Triage: This needs to be filled out with actual scenarios; MSBuild SDK, targeting packages, Xamarin SDK, etc and broken up into features.

@davkean davkean mentioned this issue Mar 20, 2020
Closed
@davidwengier davidwengier added the Resolution-Duplicate The bug is a duplicate of another bug in this or another repo. label Apr 17, 2020
@davidwengier
Copy link
Contributor Author

Duping this against #6080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Feature-WinUI Feature-Xamarin Resolution-Duplicate The bug is a duplicate of another bug in this or another repo. Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
16.7
Development

No branches or pull requests
3 participants
@drewnoakes @davidwengier @davkean