Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoslynDev hive doesn't work as expected after running build.cmd #2463

Closed
jcouv opened this issue Jun 19, 2017 · 9 comments
Closed

RoslynDev hive doesn't work as expected after running build.cmd #2463

jcouv opened this issue Jun 19, 2017 · 9 comments
Assignees
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented Jun 19, 2017

From discussion with @panopticoncentral, running build.cmd is not sufficient to properly set up project system for testing in hive.
This came up in the context of validating the ref assembly change for FUTD check. My setup was incorrect.

The contribution guide should be updated, or build.cmd should be fixed:

From the command-line, after you've run build.cmd, you can launch a Visual Studio instance with your recently built bits by running the following from a Visual Studio Command Prompt:
devenv /rootsuffix RoslynDev

Relates to #2254 (comment)

@davkean
Copy link
Member

davkean commented Jun 19, 2017

@jcouv This must have been broken, let me investigate...

@davkean
Copy link
Member

davkean commented Jun 19, 2017

Hmm, this looks right to me, can you do the following:

  1. Delete every folder in C:\Users\jcouv\AppData\Local\Microsoft\VisualStudio that ends in RoslynDev
  2. Run build.cmd

You should now see the following folders under:

image

Also verified that we load those bits from a fresh hive:

image

@srivatsn
Copy link
Contributor

For the rules to take effect some env vars need to be set. For that - you need to F5 from VS (launchSettings.json sets them) or we need build.cmd to set them.

@davkean
Copy link
Member

davkean commented Jun 19, 2017

@srivatsn Ah, the rules...may be we need a launch that sets it. Having the build set it seems wrong.

@srivatsn
Copy link
Contributor

We should create a batch file and update the contribution guide

@srivatsn srivatsn added the Bug label Jul 24, 2017
@srivatsn srivatsn added this to the 15.5 milestone Jul 24, 2017
@Pilchie Pilchie modified the milestones: 15.5, 15.6 Oct 17, 2017
@Pilchie
Copy link
Member

Pilchie commented Dec 20, 2017

Note that the current root suffix is ProjectSystem not RoslynDev too. Related to adoption of RepoToolset?

@davkean
Copy link
Member

davkean commented Jan 3, 2018

I updated the contribution guide instead of adding a command-line batch script. It's just a couple of environment variables.

@davkean davkean closed this as completed Jan 3, 2018
@doivosevic
Copy link

@davkean what was the doc change? I have a feeling I'm missing some step to update the extensions my RoslynDev instance is using.

I'm on dev16.0 branch with my changes applied to it (some parser and lexer experiments I'm doing).
I want to try out the new compiler both in Visual studio experience and the compiler.

I cleaned my git repo. I removed the RoslynDev folder from AppData.
I run
.\Restore.cmd; .\Build.cmd
and then
& "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe" /RootSuffix RoslynDev

For some reason I'm still using a version of the compiler with SOME of the changes I did. I managed to try out my changes in this experimental instance a week ago but now I can't get the RoslynDev to use the latest version of my binaries.

Please help

@davkean
Copy link
Member

davkean commented Mar 3, 2019

@DominikDitoIvosevic This is the project-system, Roslyn's contribution guide is here: https://github.com/dotnet/roslyn/wiki/Contributing-Code.

@drewnoakes drewnoakes removed the Bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants