-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TryGetValue_False_FrozenDictionary benchmark #3432
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding a new case for 20 items designed to benchmark the length optimizations.
I ran the benchmarks against 3 versions of .NET runtime.
main
- main branch as of yesterdaynolength
- I removed the existingif ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff)
check for comparison's sakepr92546
- dotnet/runtime#92546 which adds a new length filterHere are the results:
I believe the new
Count = 20
scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.Although the effects of PR92546 are also visible in the
Count=100
scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.